Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztp: CNF-14638: Cherry pick CLO6 changes to release-4.17 #2044

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2024
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14458 which is a valid jira issue.

In response to this:

  • Includes both PRs that were merged into main (!2028, !2042)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@fontivan fontivan changed the base branch from master to release-4.17 September 20, 2024 21:42
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14458 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

  • Includes both PRs that were merged into main (!2028, !2042)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fontivan
Copy link
Contributor Author

/hold do not merge for now

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
@sabbir-47
Copy link
Contributor

@fontivan Why are we manually cherrypicking to 4.17 and not using the git workflow?

@fontivan
Copy link
Contributor Author

@fontivan Why are we manually cherrypicking to 4.17 and not using the git workflow?

I wanted to keep both changes together in one PR to make the backport a bit cleaner

@fontivan fontivan changed the title ztp: CNF-14458: Cherry pick CLO6 changes to release-4.17 ztp: CNF-14638: Cherry pick CLO6 changes to release-4.17 Sep 24, 2024
@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14638 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Includes both PRs that were merged into main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…om fontivan/sskeard/ocpbugs-41368-cluster-logging-6point0'

ztp: CNF-14458: Update source CRs to use Cluster Logging Operator (CLOG) 6.0
…om fontivan/sskeard/cnf-14458-update-channel-name-for-clo'

ztp: CNF-14458: Follow up fixes for channel name & kubecompare-references
…om fontivan/sskeard/cnf-14458-fix-missing-service-account-from-examples'

ztp: CNF-14458: Add cluster log service account CRs to argocd example…
@fontivan fontivan force-pushed the sskeard/cnf-14458-cherry-pick-to-417 branch from 0388849 to 30ac21e Compare September 24, 2024 12:46
…om lack/clo6_reference_fix'

ztp: reference: Fix ClusterLogServiceAccount filenames
@fontivan fontivan force-pushed the sskeard/cnf-14458-cherry-pick-to-417 branch from 162eb7e to 1d276c8 Compare September 24, 2024 17:13
@fontivan
Copy link
Contributor Author

Undrafting PR to allow CI to run though PR still held pending final approvals

@fontivan fontivan marked this pull request as ready for review September 24, 2024 17:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2024
@fontivan
Copy link
Contributor Author

/hold do not merge yet

@fontivan
Copy link
Contributor Author

cc. @imiller0 @sabbir-47 @lack require an approval and a lgtm for this

@fontivan
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2024
…rRoleBindings

- ClusterRoleBindings do not have namespaces, and it is currently being ignored when the resources are created
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan, lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d3061b7 into openshift-kni:release-4.17 Sep 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants