-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ztp: CNF-14638: Cherry pick CLO6 changes to release-4.17 #2044
ztp: CNF-14638: Cherry pick CLO6 changes to release-4.17 #2044
Conversation
@fontivan: This pull request references CNF-14458 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
@fontivan: This pull request references CNF-14458 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold do not merge for now |
@fontivan Why are we manually cherrypicking to 4.17 and not using the git workflow? |
I wanted to keep both changes together in one PR to make the backport a bit cleaner |
@fontivan: This pull request references CNF-14638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…om fontivan/sskeard/ocpbugs-41368-cluster-logging-6point0' ztp: CNF-14458: Update source CRs to use Cluster Logging Operator (CLOG) 6.0
…om fontivan/sskeard/cnf-14458-update-channel-name-for-clo' ztp: CNF-14458: Follow up fixes for channel name & kubecompare-references
…om fontivan/sskeard/cnf-14458-fix-missing-service-account-from-examples' ztp: CNF-14458: Add cluster log service account CRs to argocd example…
0388849
to
30ac21e
Compare
…om lack/clo6_reference_fix' ztp: reference: Fix ClusterLogServiceAccount filenames
162eb7e
to
1d276c8
Compare
Undrafting PR to allow CI to run though PR still held pending final approvals |
/hold do not merge yet |
cc. @imiller0 @sabbir-47 @lack require an approval and a lgtm for this |
/unhold |
…rRoleBindings - ClusterRoleBindings do not have namespaces, and it is currently being ignored when the resources are created
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fontivan, lack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d3061b7
into
openshift-kni:release-4.17
Includes 5 PRs that were merged into main