Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ztp: updates Containerfile builder #2012

Closed
wants to merge 1 commit into from
Closed

ztp: updates Containerfile builder #2012

wants to merge 1 commit into from

Conversation

rauhersu
Copy link
Contributor

No description provided.

@rauhersu
Copy link
Contributor Author

/hold

We need Prow config working in 4.17 firstly

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@rauhersu rauhersu mentioned this pull request Aug 28, 2024
Merged
@nishant-parekh
Copy link
Member

please use ztp: in your commit message to fix the prow/ci job failing.

nishant-parekh
nishant-parekh suggested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@nishant-parekh nishant-parekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update commit message

@rauhersu rauhersu force-pushed the release-4.17.fix.Containerfile branch from 5418bd3 to c78b5a8 Compare August 29, 2024 09:51
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rauhersu
Once this PR has been reviewed and has the lgtm label, please ask for approval from nishant-parekh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rauhersu rauhersu changed the title updates Containerfile builder ztp: updates Containerfile builder Aug 29, 2024
@rauhersu
Copy link
Contributor Author

update commit message

Thanks @nishant-parekh , done !

@rauhersu
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@rauhersu
Copy link
Contributor Author

ping @nishant-parekh

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@rauhersu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ci-tests c78b5a8 link true /test e2e-aws-ci-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fontivan
Copy link
Contributor

Fixed in #2091
@rauhersu this can be closed

@rauhersu rauhersu closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishant-parekh nishant-parekh nishant-parekh requested changes

@imiller0 imiller0 Awaiting requested review from imiller0

Assignees

@nishant-parekh nishant-parekh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rauhersu @nishant-parekh @fontivan