Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: nto:sriov: rps configuration validation test #1856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Apr 1, 2024

We are lack coverage of RPS configuration validation on a cluster with SR-IOV devices. This test aim to cover the above mentioned gap.

The test tries to detect the PerformanceProfile (creates one if needed), and creates an SRI-OV network. Then the test validates that all NICs are configured with the correct RPS mask.

@openshift-ci-robot
Copy link
Collaborator

@Tal-or: This pull request explicitly references no jira issue.

In response to this:

We are lack coverage of RPS configuration validation on a cluster with SR-IOV devices. This test aim to cover the above mentioned gap.

The test tries to detect the PerformanceProfile (creates one if needed), and creates an SRI-OV network. Then the test validates that all NICs are configured with the correct RPS mask.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 1, 2024

/test e2e-telco5g-cnftests

@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 1, 2024

/cc @SchSeba

@zeeke
Copy link
Member

zeeke commented Apr 2, 2024

/test ?

Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

@zeeke: The following commands are available to trigger required jobs:

  • /test ci
  • /test e2e-aws-ci-tests
  • /test images
  • /test ztp-ci

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ran-profile
  • /test e2e-telco5g-cnftests
  • /test security

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-kni-cnf-features-deploy-master-ci
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ci-tests
  • pull-ci-openshift-kni-cnf-features-deploy-master-e2e-aws-ran-profile
  • pull-ci-openshift-kni-cnf-features-deploy-master-images
  • pull-ci-openshift-kni-cnf-features-deploy-master-security

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Member

ffromani commented Apr 2, 2024

/rename NO-JIRA: nto:sriov: rps configuration validation test

@ffromani ffromani changed the title NO-JIRA: nto:srivo: rps configuration validation test NO-JIRA: nto:sriov: rps configuration validation test Apr 2, 2024
Copy link
Member

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@Tal-or
Copy link
Contributor Author

Tal-or commented Apr 2, 2024

/test e2e-telco5g-cnftests

cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
machineConfigPoolName string
performanceProfileName string
enforcedPerformanceProfileName string
dpdkResourceName = "dpdknic"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not for dpdk right? it's for regular kernel device

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchSeba Yes. I copied the name from a different test.
Which name are you suggesting to use?

cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
cnf-tests/testsuites/e2esuite/rps/rps.go Outdated Show resolved Hide resolved
We are lack coverage of RPS configuration validation on a cluster with SR-IOV devices.
This test aim to cover the above mentioned gap.

The test tries to detect the PerformanceProfile (creates one if needed), and creates an SRI-OV network.
Then the test validates that all NICs are configured with the correct RPS mask.

Signed-off-by: Talor Itzhak <[email protected]>
@Tal-or
Copy link
Contributor Author

Tal-or commented Sep 3, 2024

/test e2e-telco5g-cnftests

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@Tal-or: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-telco5g-cnftests d0f12ae link false /test e2e-telco5g-cnftests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants