Allow provider to use the external ID when assuming the role in the p… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9rnt
requested review from
peterzhuamazon,
prudhvigodithi,
jackson-theisen and
phillbaker
as code owners
…rovider configuration set up Signed-off-by: mannai2 <[email protected]>
phillbaker
approved these changes
Jul 23, 2023
prudhvigodithi
added
the
backport 1.x
|
Hey can you please backport this to |
Open
|
Since version 2 of the provider is not yet released, having this merged to v1 will be useful to get role assumption working and releasing a new version of the provider to terraform registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rovider configuration set up
Description
The provider needs the external ID configured in the condition of the IAM policy if it's set in the role iam policy when using assume role configuration
Issues Resolved
Close issue phillbaker/terraform-provider-elasticsearch#346
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.