support for date time parameters #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sumukhswamy <[email protected]>
sumukhswamy
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
reviewed
Feb 10, 2025
src/main/kotlin/org/opensearch/reportsscheduler/model/ReportDefinition.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/reportsscheduler/action/ReportInstanceActions.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: sumukhswamy <[email protected]>
Signed-off-by: sumukhswamy <[email protected]>
joshuali925
approved these changes
Feb 12, 2025
|
Sure I will do that |
ps48
approved these changes
Feb 14, 2025
|
@sumukhswamy we need tests to support both legacy and new definitions |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
* support for date time parameters Signed-off-by: sumukhswamy <[email protected]> * change condition to support older parameters as well Signed-off-by: sumukhswamy <[email protected]> * remove comments Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> (cherry picked from commit 31fe5b7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for date and time parameters in the front-end code for PR: opensearch-project/dashboards-reporting#524
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.