fix EmptyButton text line-height #1490
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `line-height: inherit` introduced by opensearch-project#1342 and use `display: flex` to fix the original issue. With this commit, it also fixed the issue described in opensearch-project#1486 Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
AMoo-Miki,
bandinib-amzn,
ashwin-pc,
joshuarrrr and
virajsanghvi
as code owners
Signed-off-by: Yulong Ruan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
line-height: inheritintroduced by #1342 and usedisplay: flexto fix the original issue. I believe the buttonline-heightshould notinheritas it will inherit the line-height of its parent which may result in unexpected behavior, see issue and comments in #1486With this commit, it also fixed the issue described in #1486
Description
Before
After
Issues Resolved
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.