[OSCI][BUG] Fixing bug in icon-only buttons for showing info tooltip when hovered #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
BigSamu
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
BigSamu
changed the title
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
BSFishy
reviewed
Dec 4, 2023
… undefined in className instead of empty string) Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
|
I found a problem with the documentation page of the
Is there any issue with this? Do you know what could be causing this? Also, I realized that for the case of the examples of many buttons (not group buttons), Regards, Samuel |
This seems to be a bigger issue. I did a little bit of digging and found that the docinfo isn't being generated for |
joshuarrrr
requested changes
Dec 8, 2023
src/components/accessibility/__snapshots__/skip_link.test.tsx.snap
Outdated
Show resolved
Hide resolved
…t in buttonIcon and updating snapshots Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
BigSamu
commented
Jan 1, 2024
|
Last updates requested are done. I added comments in a code review above so you can check the exact changes I made. I am still a bit confused about how to use snapshots. But I would bring that question to the following community office hours. Regards, Samuel |
BSFishy
approved these changes
Jan 2, 2024
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
ashwin-pc
approved these changes
Jan 11, 2024
ashwin-pc
approved these changes
Jan 11, 2024
|
Revies asked are resolved. Could you check for proceeding with a merge? |
joshuarrrr
approved these changes
Jan 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
…when hovered (#1160) * fixing bug in icon-only buttons for showing info tooltip Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Updating test snapshoots related to change in button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Updating chanelog.md regarding update in OuiButtonContent Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating button_content.tsx using recomendation of mantainer (include undefined in className instead of empty string) Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating test snapshoots for button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * adding title prop to OuiIcon component, removing wrapping span element in buttonIcon and updating snapshots Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * refactoring code for buttonIcon variable to keep more concise definition Signed-off-by: Samuel Valdes Gutierrez <[email protected]> --------- Signed-off-by: Samuel Valdes Gutierrez <[email protected]> (cherry picked from commit 96af93e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
BigSamu
added a commit
to BigSamu/oui
that referenced
this pull request
Jan 13, 2024
…tooltip when hovered (opensearch-project#1160)" This reverts commit 96af93e.
AMoo-Miki
pushed a commit
that referenced
this pull request
Jan 25, 2024
…when hovered (#1160) (#1206) * fixing bug in icon-only buttons for showing info tooltip Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Updating test snapshoots related to change in button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Updating chanelog.md regarding update in OuiButtonContent Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating button_content.tsx using recomendation of mantainer (include undefined in className instead of empty string) Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating test snapshoots for button_content.tsx Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * adding title prop to OuiIcon component, removing wrapping span element in buttonIcon and updating snapshots Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * refactoring code for buttonIcon variable to keep more concise definition Signed-off-by: Samuel Valdes Gutierrez <[email protected]> --------- Signed-off-by: Samuel Valdes Gutierrez <[email protected]> (cherry picked from commit 96af93e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Icon-only buttons are not showing descriptive tooltip when hovered. This PR fixes the problem by adding wrapping a tag with
textPropsto a<buttonIcon/>componentIssues Resolved
Issue #1129
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.