feat(grpc): Add gRPC vector bulk ingestion with extra_field_values#1047
Draft
finnegancarroll wants to merge 1 commit into
Draft
feat(grpc): Add gRPC vector bulk ingestion with extra_field_values#1047finnegancarroll wants to merge 1 commit into
finnegancarroll wants to merge 1 commit into
Conversation
Add support for bulk indexing vectors over gRPC using the extra_field_values optimization from OpenSearch PR #20635. Vectors are sent as packed little-endian binary (FloatBinaryLE) via the protobuf extra_field_values side-channel, bypassing JSON serialization entirely. - Add build_proto_vector_request() to ProtoBulkHelper for building BulkRequest with FloatBinaryLE encoding in extra_field_values map - Add ProtoBulkVectorsFromDataSetParamSource that reads HDF5 vectors as numpy arrays and passes them as binary (no .tolist() conversion) - Add ProtoBulkVectorDataSet runner and OperationType (204) - Bump opensearch-protobufs dependency from ==1.2.0 to >=1.4.0 - Add 7 unit tests covering protobuf message construction and param source behavior
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit a5323d8.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for bulk indexing vectors over gRPC using the extra_field_values optimization from OpenSearch PR #20635. Vectors are sent as packed little-endian binary (FloatBinaryLE) via the protobuf extra_field_values side-channel, bypassing JSON serialization entirely.
Issues Resolved
N/A
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.