-
Notifications
You must be signed in to change notification settings - Fork 176
[Agentic Memory] Allow other LLMs for Fact Extraction #4159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Agentic Memory] Allow other LLMs for Fact Extraction #4159
Conversation
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/opensearch/ml/common/memorycontainer/MemoryContainerConstants.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Outdated
Show resolved
Hide resolved
The failing ITs are because of usage of deprecated Bedrock models.
Will raise another PR to fix |
Cool. Let's raise the PR to fix the integ suite. Then we can upgrade the branch with the change to run the integ test again. Thanks. |
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Show resolved
Hide resolved
...n/src/main/java/org/opensearch/ml/action/memorycontainer/memory/MemoryProcessingService.java
Show resolved
Hide resolved
} | ||
facts = (List<String>) dataMap.get(FACTS_FIELD); | ||
} catch (Exception e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are catching a generic exception and then throwing a 400 level exception. Can we try to catch specific exceptions to provide better error context?
d5be8fb
to
429959f
Compare
Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
Signed-off-by: rithin-pullela-aws <[email protected]>
429959f
to
94038e9
Compare
Signed-off-by: rithin-pullela-aws <[email protected]>
Description
With this PR we expect the users to pass
response_filter
in parameters of the LLM connectors and thus allowing more flexible LLM options for fact extraction in Agentic Memory. This also means we can have a more flexible connector request body without tying to only claude models.To use a Claude model:
To use Open AI models:
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.