-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added amazon rekognition as a trust endpoint #3419
Added amazon rekognition as a trust endpoint #3419
Conversation
Signed-off-by: Pavan Yekbote <[email protected]>
Have you tested with making a prediction call if that works? |
I tried to create the connector with a rekognition url and it succeeded. I will validate the entire workflow once. |
… on region Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
Signed-off-by: Pavan Yekbote <[email protected]>
@dhrubo Successfully hit predict api without adding endpoint to trusted urls manually |
Compilation fails |
Seems main is currently not compiling. might be due to lucene upgrade |
This PR should fix the issue: #3426 |
Failing due to unrelated changes
|
Signed-off-by: Pavan Yekbote <[email protected]>
spotless check? |
Signed-off-by: Pavan Yekbote <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3419-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25e6c9a279df16f4ff1c9a4bcb9e4cf5cd7af91c
# Push it to GitHub
git push --set-upstream origin backport/backport-3419-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* feat: add rekognition trust endpoint Signed-off-by: Pavan Yekbote <[email protected]> * refactor: consistent regex with previous connectors and looser checks on region Signed-off-by: Pavan Yekbote <[email protected]> * test: add test case to validate connector creation successful Signed-off-by: Pavan Yekbote <[email protected]> * chore: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * chore: linter fixes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]>
…int (#3445) * Added amazon rekognition as a trust endpoint (#3419) * feat: add rekognition trust endpoint Signed-off-by: Pavan Yekbote <[email protected]> * refactor: consistent regex with previous connectors and looser checks on region Signed-off-by: Pavan Yekbote <[email protected]> * test: add test case to validate connector creation successful Signed-off-by: Pavan Yekbote <[email protected]> * chore: spotless apply Signed-off-by: Pavan Yekbote <[email protected]> * chore: linter fixes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]> * fix: handle conflict due to deepseek changes Signed-off-by: Pavan Yekbote <[email protected]> --------- Signed-off-by: Pavan Yekbote <[email protected]>
Description
Adds amazon rekognition url to trusted urls by default preventing user from having to manually add it to use the model.
I have also added (-fips) as an optional string to the regex based on the below link. Please suggest if this seems alright.
Reference: https://docs.aws.amazon.com/general/latest/gr/rekognition.html
Related Issues
Resolves #3308
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.