Introduce VectorScorers to create VectorScorer instances based on the underlying vector storage format#3183
Open
VijayanB wants to merge 1 commit intoopensearch-project:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
============================================
+ Coverage 82.66% 82.68% +0.01%
- Complexity 3980 3993 +13
============================================
Files 431 433 +2
Lines 14783 14822 +39
Branches 1882 1887 +5
============================================
+ Hits 12221 12255 +34
- Misses 1801 1807 +6
+ Partials 761 760 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VijayanB
force-pushed
the
add-scorer-factory
branch
2 times, most recently
from
15f917a to
98bc52e
Compare
VijayanB
changed the title
VijayanB
requested review from
0ctopus13prime,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
Member
Author
|
This is based on #3179 . Once the other PR is merged, will rebase again. |
VijayanB
changed the title
Vikasht34
reviewed
Mar 18, 2026
Collaborator
Vikasht34
left a comment
Vikasht34
left a comment
There was a problem hiding this comment.
I am confused on this PR , Please re-bases the have only changes which was not there in Last one.
5 tasks
VijayanB
force-pushed
the
add-scorer-factory
branch
from
fc76f62 to
358683d
Compare
…oring Introduce VectorScorerFactory to create VectorScorer instances based on the underlying vector storage format (BinaryDocValues, FloatVectorValues, ByteVectorValues). Add ScoreMode interface to abstract scorer vs rescorer creation. - Add ScoreMode with SCORE and RESCORE strategies - Add VectorScorerFactory with float and byte target overloads - Add ADC scorer with TODO to remove once ByteVectorValues.scorer() is implemented Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
add-scorer-factory
branch
from
358683d to
02ec458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce VectorScorerFactory to create VectorScorer instances based on
the underlying vector storage format (BinaryDocValues, FloatVectorValues,
ByteVectorValues). Add ScoreMode interface to abstract scorer vs rescorer
creation.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.