Deprecate confidence_interval parameter in Lucene Scalar Quantizer#3168
Draft
naveentatikonda wants to merge 2 commits intoopensearch-project:mainfrom
Draft
Deprecate confidence_interval parameter in Lucene Scalar Quantizer#3168naveentatikonda wants to merge 2 commits intoopensearch-project:mainfrom
naveentatikonda wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
naveentatikonda
requested review from
VijayanB,
heemin32,
jmazanec15,
junqiu-lei,
martin-gaievski,
navneet1v,
ryanbogan and
vamshin
as code owners
naveentatikonda
requested review from
0ctopus13prime,
luyuncheng and
shatejas
as code owners
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
deprecate_sq_ci
branch
from
98f083f to
10be79d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3168 +/- ##
=========================================
Coverage 82.57% 82.58%
+ Complexity 3948 3947 -1
=========================================
Files 426 426
Lines 14677 14679 +2
Branches 1875 1876 +1
=========================================
+ Hits 12120 12123 +3
+ Misses 1796 1794 -2
- Partials 761 762 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
confidence_intervalparameter in the Lucene SQ encoder is deprecated as of OpenSearch 3.6.0 and will be removed in a future release.confidence_intervalwas originally passed toLucene99ScalarQuantizedVectorsFormat, but Lucene dropped support for it inLucene104HnswScalarQuantizedVectorsFormat— the confidence interval is now computed automatically from vector dimensionality. The KNN1040 codec currently preserves the parameter via the backward-compatibleLucene99RWHnswScalarQuantizedVectorsFormat, but it will have no effect in future codec versions.Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.