Skip to content

Cosine Similarity Multi Shard Testing#2977

Open
MrFlap wants to merge 1 commit intoopensearch-project:mainfrom
MrFlap:multinode-test
Open

Cosine Similarity Multi Shard Testing#2977
MrFlap wants to merge 1 commit intoopensearch-project:mainfrom
MrFlap:multinode-test

Conversation

@MrFlap
Copy link
Contributor

@MrFlap MrFlap commented Nov 3, 2025

Description

Adds testing for multi shard cosine similarity.

Related Issues

Adds more general integration tests to PR #2974

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MrFlap MrFlap changed the title Multinode test Cosine Similarity Multi Shard and Multi Node Testing Nov 3, 2025
@MrFlap MrFlap force-pushed the multinode-test branch 6 times, most recently from fdfca24 to e534928 Compare November 4, 2025 00:06
@MrFlap MrFlap force-pushed the multinode-test branch 6 times, most recently from 8bd48a4 to 9f92b84 Compare November 5, 2025 19:14
Copy link
Collaborator

@0ctopus13prime 0ctopus13prime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.
But could you add the suffix "IT" for each case? I think your added test cases are not being running.
Also please ensure add 'test' as a prefix for the testing method to make sure have it executed.

@MrFlap MrFlap force-pushed the multinode-test branch 2 times, most recently from 3446000 to 5449246 Compare November 5, 2025 19:28
@MrFlap MrFlap force-pushed the multinode-test branch 2 times, most recently from 65f4e0a to 2d1aacd Compare November 6, 2025 19:16
@MrFlap MrFlap changed the title Cosine Similarity Multi Shard and Multi Node Testing Cosine Similarity Multi Shard Testing Nov 6, 2025
@MrFlap MrFlap force-pushed the multinode-test branch 3 times, most recently from 194efee to e64a52b Compare November 7, 2025 00:06
@MrFlap MrFlap force-pushed the multinode-test branch 12 times, most recently from 000c717 to f8a865a Compare November 11, 2025 22:10
shatejas
shatejas previously approved these changes Jan 13, 2026
@navneet1v
Copy link
Collaborator

navneet1v commented Jan 14, 2026

@MrFlap can we fix the merge conflicts

1 similar comment
@navneet1v
Copy link
Collaborator

@MrFlap can we fix the merge conflicts

@MrFlap MrFlap force-pushed the multinode-test branch 2 times, most recently from 7321630 to 655ec06 Compare February 3, 2026 19:55
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.47%. Comparing base (8a09fbc) to head (2966982).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2977   +/-   ##
=========================================
  Coverage     82.47%   82.47%           
  Complexity     3825     3825           
=========================================
  Files           414      414           
  Lines         14315    14315           
  Branches       1828     1828           
=========================================
  Hits          11806    11806           
  Misses         1754     1754           
  Partials        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrFlap MrFlap force-pushed the multinode-test branch 2 times, most recently from dcf107c to 2966982 Compare February 3, 2026 23:19
Signed-off-by: Andrew Klepchick <aklepchi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants