Cosine Similarity Multi Shard Testing#2977
Open
MrFlap wants to merge 1 commit intoopensearch-project:mainfrom
Open
Cosine Similarity Multi Shard Testing#2977MrFlap wants to merge 1 commit intoopensearch-project:mainfrom
MrFlap wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
fdfca24 to
e534928
Compare
shatejas
reviewed
Nov 4, 2025
src/test/java/org/opensearch/knn/index/CosineSimilarityMultiNodeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/SimilarityMultiNodeTestIT.java
Outdated
Show resolved
Hide resolved
8bd48a4 to
9f92b84
Compare
src/test/java/org/opensearch/knn/index/SimilarityMultiNodeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/SimilarityMultiNodeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/SimilarityMultiNodeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/SimilarityMultiShardTestIT.java
Outdated
Show resolved
Hide resolved
3446000 to
5449246
Compare
65f4e0a to
2d1aacd
Compare
194efee to
e64a52b
Compare
shatejas
reviewed
Nov 7, 2025
src/test/java/org/opensearch/knn/index/SimilarityMultiShardTestIT.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/knn/index/SimilarityMultiShardTestIT.java
Outdated
Show resolved
Hide resolved
000c717 to
f8a865a
Compare
shatejas
previously approved these changes
Jan 13, 2026
Collaborator
|
@MrFlap can we fix the merge conflicts |
1 similar comment
Collaborator
|
@MrFlap can we fix the merge conflicts |
7321630 to
655ec06
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2977 +/- ##
=========================================
Coverage 82.47% 82.47%
Complexity 3825 3825
=========================================
Files 414 414
Lines 14315 14315
Branches 1828 1828
=========================================
Hits 11806 11806
Misses 1754 1754
Partials 755 755 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcf107c to
2966982
Compare
Signed-off-by: Andrew Klepchick <aklepchi@amazon.com>
2966982 to
dc3e093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds testing for multi shard cosine similarity.
Related Issues
Adds more general integration tests to PR #2974
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.