Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to publish jar to maven #2473

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Changes to publish jar to maven #2473

wants to merge 1 commit into from

Conversation

kannangce
Copy link

@kannangce kannangce commented Jan 30, 2025 •
edited
Loading

Description

Changes to publish the jar of knn plugin to maven.

Related Issues

Resolves #1351

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Testing:

Since it is a call to an existing gradle task. I couldn't exactly test it.
But I'm to run the equivalent task publishNebulaPublicationToMavenLocal and use the locally published jar from my another project.

@kannangce kannangce mentioned this pull request Jan 30, 2025
Closed
5 tasks
@kannangce
Copy link
Author

Seems like this doesn't required change-log as suggested in the contribution guide.

So this requires adding of skip-changelog to the PR. Reviewers please help with that.

jmazanec15
jmazanec15 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

@shatejas shatejas Awaiting requested review from shatejas shatejas is a code owner

@0ctopus13prime 0ctopus13prime Awaiting requested review from 0ctopus13prime 0ctopus13prime is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport main skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kannangce @jmazanec15 @shatejas