[Backport 2.x] Fix setting rescore as false in on_disk knn_vector query #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-emoto
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas and
0ctopus13prime
as code owners
qa/restart-upgrade/src/test/java/org/opensearch/knn/bwc/WarmupIT.java
Outdated
Show resolved
Hide resolved
navneet1v
approved these changes
Jan 23, 2025
e-emoto
force-pushed
the
backport/backport-2399-to-2.x
branch
from
155f6ee to
c37ebde
Compare
kotwanikunal
approved these changes
Jan 23, 2025
…project#2399) * Fix setting rescore as false in on_disk knn_vector query Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> * Update CHANGELOG.md Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> * Reapply Spotless Java Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> * Add IT for testing rescore enabled and disabled Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> --------- Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 387344e) Signed-off-by: Ethan Emoto <[email protected]>
e-emoto
force-pushed
the
backport/backport-2399-to-2.x
branch
from
c37ebde to
7516b69
Compare
jmazanec15
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2399
Skip Flaky BWC in #2417
This change adds a flag to RescoreContext for tracking if rescore has been disabled by the KNN query parameters. This flag is set to not skip rescore by default, and is only set to skip rescore if
"rescore": falseis in the KNN query. UTs were added for the KNNQueryBuilderParser that covers the different cases for rescore. The below steps were also run with a debugging cluster to verify that the rescore was being run/skipped correctly based on the query parameters.Related Issues
Resolves #2360
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.