Pipeline Runner Implementation and Tests #5435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammed Aghil Puthiyottil <[email protected]>
MohammedAghil
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
reviewed
Feb 18, 2025
| } | ||
| try { | ||
| pipelineRunner.runAllProcessorsAndPublishToSinks(); | ||
| } catch (InvalidEventHandleException exception) { |
There was a problem hiding this comment.
Why not catch and handle this in PipelineRunner?
There was a problem hiding this comment.
Thanks for the suggestion @dlvenable , I have moved this into PipelineRunner
| import java.util.stream.IntStream; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class PipelineRunnerTest { |
There was a problem hiding this comment.
Did you copy and paste these tests? Are any new or modified?
There was a problem hiding this comment.
I have added some new tests and also moved some tests from ProcessWorker to PipelineRunnerTest as the functionality moved.
| @@ -135,6 +135,7 @@ void setup() { | |||
| when(pipeline.isStopRequested()).thenReturn(false).thenReturn(true); | |||
| when(source.areAcknowledgementsEnabled()).thenReturn(true); | |||
| when(pipeline.getSource()).thenReturn(source); | |||
| when(pipeline.getBuffer()).thenReturn(buffer); | |||
There was a problem hiding this comment.
Why did you need to include this?
There was a problem hiding this comment.
Like we discussed, The AggregateProcessorITWithAcks creates an instance of the ProcessWorker which makes it complicated to test with PipelineRunner
…ests Signed-off-by: Mohammed Aghil Puthiyottil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At Present, the functionalities of running a pipeline is encapsulated inside Process Worker. While this provides encapsulation, it does not provide a way for a given thread such as in the case of #5416 to execute processors and publish to sinks in a synchronous way without having an instance of Process Worker itself which contains additional responsibilities such as shutting down process for pipeline.
Implemented a concrete class for Pipeline Runner by moving and refactoring the functionalities of reading from buffer, executing processors and publishing to sinks from Process Worker to it, also added additional unit tests for coverage.
Issues Resolved
Resolves #5429
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.