[bug fix] fix precompute ordering in max & min aggregator #17505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandesh Kumar <[email protected]>
sandeshkr419
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sandeshkr419
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17505 +/- ##
============================================
+ Coverage 72.47% 72.50% +0.02%
- Complexity 65705 65762 +57
============================================
Files 5307 5307
Lines 304774 304774
Branches 44193 44193
============================================
+ Hits 220898 220965 +67
- Misses 65738 65750 +12
+ Partials 18138 18059 -79 ☔ View full report in Codecov by Sentry. |
sandeshkr419
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ordering change of pre-computation steps in Max/Min aggregator which was accidentally changed in #16733
Related Issues
For match-all cases, max/min aggregation without any parent/child aggregations can be precomputed faster than star-tree, so that's why it was prioritized over star-tree pre-computation. This ordering was modified in the above refactoring change, so making this change back.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.