Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce interface changes to support read/write blob with object me… #13757

Merged
merged 1 commit into from
May 21, 2024
Merged

Introduce interface changes to support read/write blob with object me… #13757

merged 1 commit into from
May 21, 2024

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented May 20, 2024 •
edited

Backport #13023 to 2.x

Merge Conflicts Files:
plugins/repository-s3/src/test/java/org/opensearch/repositories/s3/S3BlobContainerMockClientTests.java

Signed-off-by: Sandeep Kumawat [email protected]

Related Issues

Resolves []

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@skumawat2025 skumawat2025 self-assigned this May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5395322: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 31c8ff7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a945a33: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the backport-13023-to-2.x branch 2 times, most recently from d5ad025 to 4a77bd0 Compare May 21, 2024 05:25
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d5ad025: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4a77bd0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ae1e6e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 35a5b30: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 force-pushed the backport-13023-to-2.x branch 2 times, most recently from f2c4efa to c4d4be8 Compare May 21, 2024 09:04
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c4d4be8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025
Introduce interface changes to support read/write blob with object me…
0b34861 
…tadata (opensearch-project#13023)

* Introduce interface changes to read/write blob with object metadata
---------
Signed-off-by: Sandeep Kumawat <[email protected]>
Co-authored-by: Sandeep Kumawat <[email protected]>
(cherry picked from commit 9b0f578)
Signed-off-by: Sandeep Kumawat <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f2c4efa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 0b34861: SUCCESS

@codecov Codecov
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 71.31%. Comparing base (0dd892c) to head (0b34861).
Report is 260 commits behind head on 2.x.

Files Patch % Lines
...nsearch/common/blobstore/BlobDownloadResponse.java 0.00% 6 Missing ⚠️
...org/opensearch/common/blobstore/BlobContainer.java 0.00% 3 Missing ⚠️
...arch/common/blobstore/stream/read/ReadContext.java 76.92% 3 Missing ⚠️
...ch/common/blobstore/stream/write/WriteContext.java 91.30% 2 Missing ⚠️
...ex/translog/transfer/BlobStoreTransferService.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13757      +/-   ##
============================================
+ Coverage     71.28%   71.31%   +0.03%     
- Complexity    60145    61304    +1159     
============================================
  Files          4957     5037      +80     
  Lines        282799   288256    +5457     
  Branches      41409    42110     +701     
============================================
+ Hits         201591   205572    +3981     
- Misses        64189    65327    +1138     
- Partials      17019    17357     +338

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skumawat2025 skumawat2025 mentioned this pull request May 21, 2024
Merged
8 tasks
@skumawat2025 skumawat2025 marked this pull request as ready for review May 21, 2024 10:54
@sachinpkale sachinpkale merged commit fe89133 into opensearch-project:2.x May 21, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinpkale sachinpkale sachinpkale approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@skumawat2025 skumawat2025

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skumawat2025 @sachinpkale