Skip to content

Add local mapfile merging to osg-comanage-project-usermap (INF-2273) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

williamnswanson
Copy link
Collaborator

@williamnswanson williamnswanson commented Sep 5, 2024

Initial pass at adding merging of local mapfiles into the mapfile generated by osg-comanage-project-usermap. Use option -i when calling the script and provide a comma-separated list of paths/filenames for the local mapfiles you want merged in.

For Jira issue INF-2273

Initial pass at adding merging of local mapfiles into the mapfile generated by osg-comanage-project-usermap. Use option -i and provide a comma-separated list of paths/filenames for the local mapfiles you want to be merged in.
@williamnswanson williamnswanson added the enhancement New feature or request label Sep 5, 2024
@williamnswanson williamnswanson self-assigned this Sep 5, 2024
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it'll probably work but I've left a few comments to tighten things up a bit

Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamnswanson williamnswanson merged commit e8c8e06 into opensciencegrid:master Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants