Skip to content

Chore: Removed Mixins. Added them directly to OpenSCD #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chore: Removed Mixins. Added them directly to OpenSCD #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df2897b
Chore: Removed Mixins. Added them directly to OpenSCD
pascalwilbrink Aug 16, 2023
eab1e55
Chore: Updated Screenshots.
pascalwilbrink Aug 16, 2023
69f5586
Merge branch 'main' into Remove_Mixins
pascalwilbrink Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions mixins/Editing.spec.ts → editing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ import {
webUrl,
} from 'fast-check';

import { LitElement } from 'lit';

import { customElement } from 'lit/decorators.js';

import {
Edit,
Insert,
Expand All @@ -30,8 +26,11 @@ import {
newOpenEvent,
Remove,
Update,
} from '../foundation.js';
import { Editing } from './Editing.js';
} from './foundation.js';

import './open-scd.js';

import type { OpenSCD } from './open-scd.js';

export namespace util {
export const xmlAttributeName =
Expand Down Expand Up @@ -183,19 +182,14 @@ export namespace util {
)
);
}

@customElement('editing-element')
export class EditingElement extends Editing(LitElement) {}
}

describe('Editing Element', () => {
let editor: util.EditingElement;
let editor: OpenSCD;
let sclDoc: XMLDocument;

beforeEach(async () => {
editor = <util.EditingElement>(
await fixture(html`<editing-element></editing-element>`)
);
editor = <OpenSCD>await fixture(html`<open-scd></open-scd>`);
sclDoc = new DOMParser().parseFromString(
util.sclDocString,
'application/xml'
Expand Down
214 changes: 0 additions & 214 deletions mixins/Editing.ts
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions mixins/Plugging.ts
View file
Open in desktop

This file was deleted.

Loading