-
Notifications
You must be signed in to change notification settings - Fork 6
Create 0003-ADR-for-addons.md #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pascalwilbrink
wants to merge
1
commit into
main
Choose a base branch
from
adr-for-addons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# OpenSCD Core should support Addons | ||
|
||
Date: 2023-06-05 | ||
|
||
## Status | ||
|
||
Open | ||
|
||
## Context | ||
If we want OpenSCD to be extendable, we should allow OpenSCD to support `addons`. An addon is like a plugin, but without the requirement of needing to extend from `HTMLElement`. An `addon` is a default exported function from a file. | ||
an `addon` function gets the `OpenSCD` class as a parameter. from here, it can fetch the document if needed. it can also subscribe to events dispatched to `open-scd`. | ||
By implementing addons, we can minimize the risk of people forking OpenSCD and adding new functionality. If people want extra functionality on OpenSCD, they can create an addon for it. | ||
|
||
``` | ||
export default function xsdValidate(openSCD: OpenSCD) { | ||
openSCD.addEventListener('validate', (evt: ValidationEvent) => { | ||
const { doc } = openSCD; | ||
// Do actual validation to the doc. | ||
}); | ||
} | ||
``` | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Solution: background plug-in |
||
Another option is to support a new kind of plugin, `background` plugins. These plugins are rendered upon document load, like the `menu` plugins. Except these plugins are not shown in the UI. These plugins use the dom for dependency injection. | ||
|
||
When `addons` or `background plugins` are supported, it will be possible to migrate current mixins from OpenSCD into `addons` or `background plugins`. | ||
|
||
## Pros and Cons | ||
|
||
### Background plugin | ||
#### Pros | ||
It can use the current `plugin` mechanism to load. | ||
#### Cons | ||
- A background plugin is extending from `HTMLElement` but it's not rendering anything. This goes against the `CustomElement` principles. | ||
- The dom can get polluted quickly by creating background plugins | ||
|
||
### Addons | ||
#### Pros | ||
An `addon` is a function that's not depending on anything. | ||
The `addon` function gets the `OpenSCD` instance class as a parameter. | ||
|
||
#### Cons | ||
`Addons` need to be loaded apart from `plugins` . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution: Using addons