Don't persist fixtures in test database between tests

codelists/tests/test_actions.py

@@ -8,7 +8,7 @@
 from opencodelists.tests.assertions import assert_difference, assert_no_difference
 
 
-def test_create_codelist(organisation):
+def test_create_codelist(snomedct_data, organisation):
     cl = actions.create_old_style_codelist(
         owner=organisation,
         name="Test Codelist",
@@ -34,7 +34,7 @@ def test_create_codelist(organisation):
     assert clv.is_under_review
 
 
-def test_create_codelist_for_user(user):
+def test_create_codelist_for_user(snomedct_data, user):
     cl = actions.create_old_style_codelist(
         owner=user,
         name="Test Codelist",
@@ -56,7 +56,7 @@ def test_create_codelist_for_user(user):
     assert "whilst swimming" in clv.csv_data
 
 
-def test_create_codelist_with_duplicate_name(organisation):
+def test_create_codelist_with_duplicate_name(snomedct_data, organisation):
     actions.create_old_style_codelist(
         owner=organisation,
         name="Test",
@@ -81,7 +81,9 @@ def test_create_codelist_with_duplicate_name(organisation):
     assert Codelist.objects.filter(handles__name="Test").count() == 1
 
 
-def test_create_codelist_with_codes(user, disorder_of_elbow_excl_arthritis_codes):
+def test_create_codelist_with_codes(
+    snomedct_data, user, disorder_of_elbow_excl_arthritis_codes
+):
     cl = actions.create_codelist_with_codes(
         owner=user,
         name="Test",
@@ -110,7 +112,7 @@ def test_create_codelist_with_codes(user, disorder_of_elbow_excl_arthritis_codes
 
 
 def test_create_codelist_with_codes_with_metadata(
-    user, disorder_of_elbow_excl_arthritis_codes
+    snomedct_data, user, disorder_of_elbow_excl_arthritis_codes
 ):
     cl = actions.create_codelist_with_codes(
         owner=user,
@@ -129,7 +131,9 @@ def test_create_codelist_with_codes_with_metadata(
     assert cl.signoffs.count() == 1
 
 
-def test_create_or_update_codelist_create(user, disorder_of_elbow_excl_arthritis_codes):
+def test_create_or_update_codelist_create(
+    snomedct_data, user, disorder_of_elbow_excl_arthritis_codes
+):
     cl = actions.create_or_update_codelist(
         owner=user,
         name="Test",
@@ -151,15 +155,15 @@ def test_create_or_update_codelist_create(user, disorder_of_elbow_excl_arthritis
 
 
 def test_create_or_update_codelist_update(
-    organisation, codelist, disorder_of_elbow_excl_arthritis_codes
+    organisation, codelist, disorder_of_elbow_codes
 ):
     with assert_difference(codelist.versions.count, expected_difference=1):
         actions.create_or_update_codelist(
             owner=organisation,
             name=codelist.name,
             coding_system_id="snomedct",
             coding_system_database_alias=most_recent_database_alias("snomedct"),
-            codes=disorder_of_elbow_excl_arthritis_codes,
+            codes=disorder_of_elbow_codes,
             description="This is a test (updated)",
             methodology="This is how we did it (updated)",
         )
@@ -168,19 +172,19 @@ def test_create_or_update_codelist_update(
     assert codelist.description == "This is a test (updated)"
     assert codelist.methodology == "This is how we did it (updated)"
     clv = codelist.versions.order_by("id").last()
-    assert clv.codes == tuple(sorted(disorder_of_elbow_excl_arthritis_codes))
+    assert clv.codes == tuple(sorted(disorder_of_elbow_codes))
 
 
 def test_create_or_update_codelist_update_no_change_to_codes(
-    organisation, codelist, disorder_of_elbow_codes
+    organisation, codelist, disorder_of_elbow_excl_arthritis_codes
 ):
     with assert_no_difference(codelist.versions.count):
         actions.create_or_update_codelist(
             owner=organisation,
             name=codelist.name,
             coding_system_id="snomedct",
             coding_system_database_alias=most_recent_database_alias("snomedct"),
-            codes=disorder_of_elbow_codes,
+            codes=disorder_of_elbow_excl_arthritis_codes,
             description="This is a test (updated)",
             methodology="This is how we did it (updated)",
         )
@@ -476,7 +480,7 @@ def test_publish(version_under_review):
     assert version_under_review.is_published
 
 
-def test_delete_version(old_style_codelist):
+def test_delete_version(old_style_codelist, old_style_version):
     # Verify that delete_version deletes the given version, and that when the last
     # remaining version is deleted, the codelist is too.
 

codelists/tests/test_api.py

@@ -9,7 +9,11 @@
 from opencodelists.tests.assertions import assert_difference, assert_no_difference
 
 
-def test_codelists_get(client, organisation):
+def test_codelists_get(
+    client,
+    organisation,
+    many_organisation_versions,
+):
     rsp = client.get(
         f"/api/v1/codelist/{organisation.slug}/?description&methodology&references"
     )
@@ -238,7 +242,12 @@ def test_codelists_get(client, organisation):
     ]
 
 
-def test_codelists_get_all(client, organisation, organisation_user):
+def test_codelists_get_all(
+    client,
+    organisation,
+    organisation_user,
+    many_organisation_and_user_codelists,
+):
     rsp = client.get("/api/v1/codelist/?include-users")
     data = json.loads(rsp.content)
     assert rsp.status_code == 200
@@ -254,7 +263,9 @@ def test_codelists_get_all(client, organisation, organisation_user):
     assert {cl["user"] for cl in user_codelists} == {organisation_user.username}
 
 
-def test_codelists_get_with_coding_system_id(client, organisation):
+def test_codelists_get_with_coding_system_id(
+    client, organisation, many_organisation_codelists
+):
     rsp = client.get(f"/api/v1/codelist/{organisation.slug}/?coding_system_id=snomedct")
     data = json.loads(rsp.content)
     assert len(data["codelists"]) == 4
@@ -297,7 +308,9 @@ def test_codelists_get_exclude_previous_owner(
     assert len(data["codelists"]) == 0
 
 
-def test_codelists_get_with_no_organisation(client, organisation):
+def test_codelists_get_with_no_organisation(
+    client, organisation, many_organisation_and_user_codelists
+):
     rsp = client.get("/api/v1/codelist/?coding_system_id=snomedct&include-users")
     data = json.loads(rsp.content)
     user_codelists = [
@@ -308,13 +321,15 @@ def test_codelists_get_with_no_organisation(client, organisation):
         assert user_codelist["organisation"] == ""
 
 
-def test_codelists_get_with_tag(client, universe):
+def test_codelists_get_with_tag(client, many_organisation_and_user_codelists):
     rsp = client.get("/api/v1/codelist/?tag=new-style")
     data = json.loads(rsp.content)
     assert len(data["codelists"]) == 2
 
 
-def test_codelists_get_with_tag_and_include_users(client, universe):
+def test_codelists_get_with_tag_and_include_users(
+    client, many_organisation_and_user_codelists
+):
     rsp = client.get("/api/v1/codelist/?tag=new-style&include-users")
     data = json.loads(rsp.content)
     assert len(data["codelists"]) == 4

codelists/tests/test_models.py

@@ -199,6 +199,7 @@ def test_new_style_is_new_style(new_style_codelist):
 
 def test_visible_versions_user_has_edit_permissions(
     new_style_codelist,
+    version_with_complete_searches,
     user,
 ):
     assert len(new_style_codelist.visible_versions(user)) == 3

codelists/tests/views/test_codelist_create.py

@@ -34,7 +34,7 @@ def test_post_unauthorised_for_user(client, user):
     assert_post_unauthorised(client, user.get_codelist_create_url())
 
 
-def test_get_for_organisation(client, organisation):
+def test_get_for_organisation(client, organisation, organisation_user):
     force_login(organisation, client)
     response = client.get(organisation.get_codelist_create_url())
     assert response.status_code == 200
@@ -90,7 +90,7 @@ def test_post_success(client, organisation, user, bnf_data):
     assert signoff.user == user
 
 
-def test_post_invalid(client, organisation):
+def test_post_invalid(client, organisation, organisation_user):
     force_login(organisation, client)
 
     csv_data = "code,description\n0301012A0AA,Adrenaline (Asthma)"
@@ -126,7 +126,9 @@ def test_post_invalid(client, organisation):
     assert response.context_data["signoff_formset"].errors
 
 
-def test_post_with_duplicate_name(client, organisation):
+def test_post_with_duplicate_name(
+    client, organisation, organisation_user, bnf_codelist
+):
     force_login(organisation, client)
 
     csv_data = "code,description\n0301012A0AA,Adrenaline (Asthma)"

codelists/tests/views/test_index.py

@@ -25,7 +25,7 @@ def test_search_only_returns_codelists_with_published_versions(
     assert codelist.slug == "new-style-codelist"
 
 
-def test_paginate_codelists(client, organisation, create_codelists):
+def test_paginate_codelists(client, organisation, codelist, create_codelists):
     # Create enough published codelists to paginate (codelist index page is paginated by 15)
     create_codelists(30, owner=organisation, status=Status.PUBLISHED)
     published_for_organisation = [
@@ -95,7 +95,9 @@ def test_under_review_index(
         assert version.status == "under review"
 
 
-def test_paginate_under_review_versions(client, organisation, create_codelists):
+def test_paginate_under_review_versions(
+    client, organisation, version_under_review, create_codelists
+):
     # Create enough published codelists to paginate (under-review index page is paginated by 30)
     create_codelists(40, status=Status.UNDER_REVIEW, owner=organisation)
     under_review_for_organisation = flatten(

codelists/tests/views/test_version_delete.py

@@ -10,7 +10,7 @@ def test_post_unauthorised(client, version):
     assert_post_unauthorised(client, version.get_publish_url())
 
 
-def test_post_success(client, old_style_codelist):
+def test_post_success(client, organisation_user, old_style_codelist, old_style_version):
     codelist = old_style_codelist
     version1, version2 = codelist.versions.order_by("id")
     force_login(codelist, client)

codelists/tests/views/test_version_upload.py

@@ -26,14 +26,14 @@ def test_post_unauthorised(client, old_style_codelist):
     assert_post_unauthorised(client, old_style_codelist.get_version_upload_url())
 
 
-def test_get_success(client, old_style_codelist):
+def test_get_success(client, organisation_user, old_style_codelist):
     force_login(old_style_codelist, client)
     response = client.get(old_style_codelist.get_version_upload_url())
     form = response.context_data["form"]
     assert form.fields["coding_system_id"].initial == "snomedct"
 
 
-def test_post_success(client, old_style_codelist):
+def test_post_success(client, organisation_user, old_style_codelist):
     force_login(old_style_codelist, client)
 
     csv_data = "code,description\n73583000,Epicondylitis (disorder)"
@@ -47,7 +47,7 @@ def test_post_success(client, old_style_codelist):
     assert response.url == clv.get_absolute_url()
 
 
-def test_post_missing_field(client, old_style_codelist):
+def test_post_missing_field(client, organisation_user, old_style_codelist):
     force_login(old_style_codelist, client)
 
     with assert_no_difference(old_style_codelist.versions.count):

conftest.py

@@ -96,6 +96,13 @@ def reset_connections():
         del connections.databases[db]
 
 
+@pytest.fixture(autouse=True)
+def fast_password_hasher(settings):
+    settings.PASSWORD_HASHERS = [
+        "django.contrib.auth.hashers.MD5PasswordHasher",
+    ]
+
+
 ################################################################################################################
 # Setup global tracing infrastructure for testing purposes.