Skip to content

make sure the order of cdate <= duedate <= expdate #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 2, 2025

Conversation

melisabok
Copy link
Member

@melisabok melisabok commented Mar 26, 2025

  • Modify all the tests to make sure the cdate <= duedate <= expdate
  • Delete invitations instead of expiring them when a submission is deleted, withdrawn or desk rejected. The ddate doesn't need to follow any order rule.
  • Delete invitations instead of expiring them when we create the child invitations.

This is needed before merging https://github.com/openreview/openreview-api/pull/681

@melisabok melisabok marked this pull request as ready for review April 1, 2025 11:19
@enrubio
Copy link
Member

enrubio commented Apr 2, 2025

Changes look good. Just want to make sure I understand, this relates to the ordering of invitations in the venue configuration timeline right?

@carlosmondra
Copy link
Member

Changes look good. Just want to make sure I understand, this relates to the ordering of invitations in the venue configuration timeline right?

This ensures that cdate <= duedate <= expdate is always consistent in an invitation. It should avoid mistakes when changing/adding dates

Copy link
Member

@celestemartinez celestemartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! So now the _Expiration ('Withdraw_Expiration, Deletion_Expiration, etc) invitations will set a ddate instead of an expdate, correct?

@melisabok
Copy link
Member Author

Looks good! So now the _Expiration ('Withdraw_Expiration, Deletion_Expiration, etc) invitations will set a ddate instead of an expdate, correct?

Correct, I didn't change the invitation name but I could do it, I wasn't sure how to call Deletion_Expiration, Deletion_Deletion?

@enrubio
Copy link
Member

enrubio commented Apr 2, 2025

This ensures that cdate <= duedate <= expdate is always consistent in an invitation. It should avoid mistakes when changing/adding dates

I see now, thank you.

Copy link
Member

@enrubio enrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the related api PR and it looks good!

@enrubio enrubio merged commit e7e42bf into master Apr 2, 2025
6 checks passed
@enrubio enrubio deleted the fix/invitaiton-date-order branch April 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants