-
Notifications
You must be signed in to change notification settings - Fork 28
make sure the order of cdate <= duedate <= expdate #2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes look good. Just want to make sure I understand, this relates to the ordering of invitations in the venue configuration timeline right? |
This ensures that cdate <= duedate <= expdate is always consistent in an invitation. It should avoid mistakes when changing/adding dates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! So now the _Expiration
('Withdraw_Expiration, Deletion_Expiration, etc) invitations will set a ddate instead of an expdate, correct?
Correct, I didn't change the invitation name but I could do it, I wasn't sure how to call Deletion_Expiration, Deletion_Deletion? |
I see now, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the related api PR and it looks good!
ddate
doesn't need to follow any order rule.This is needed before merging https://github.com/openreview/openreview-api/pull/681