Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added applyConfigToAdmin option to manager_config.json #1289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MartinaeyNL
Copy link
Contributor

Fixes #1287

Added applyConfigToAdmin option to manager_config.json.
It controls if custom page configurations are shown to the admin user.
Defaults to true.

@richturner
Copy link
Member

I am not a fan of config that affects the admin user as quickly the admin user cannot perform actions in the manager UI (the admin tool)

@DonWillems
Copy link
Contributor

As someone who edits the manager config using the appearance page, its a bit awkward to do:
"manager": { "applyConfigToAdmin": false }

instead of directly on the same level as 'realms' and 'pages':
"applyConfigToAdmin": false

But if that code-wise makes the most sense, it's ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager UI: Add manager_config item that lets superuser ignore the config so that they can see everything
3 participants