-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend updates: Search functionality to users page #1280
Conversation
… 'live' attribute for text fields that trigger on every character change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments
…ut, so using @input listener on consumer component instead.
Put it back to a draft as it is currently WIP. |
…s not working properly for @input. (original input element needs to be referenced, but its living in the shadow dom)
Went through the requested changes, and tried out to use event bubbling instead of re-dispatching an event.
Feel free to PM me if an additional chat is necessary 😄 |
I still don't understand the need for this
Happy to have a call to clarify why this alternative approach is required |
…oved debounce after issues getting the event target element.
Thanks for referring to Removed the @DonWillems you can either deploy this on a test server first, or simply approve this. |
In regards to issue #1274, I added a search field to both "regular user" and "service user" tables,
that filters the shown items in the table. So, this filtering done locally on the client after fetching all users.
Only includes frontend changes.
Changelog;
_users
or_serviceUsers
array based onusername, email, first name, last name, et cetera. Using
@input
on the search field for live updates of the tables.