Added applyConfigToAdmin option to manager_config.json #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not a fan of config that affects the admin user as quickly the admin user cannot perform actions in the manager UI (the admin tool) |
|
As someone who edits the manager config using the appearance page, its a bit awkward to do: instead of directly on the same level as 'realms' and 'pages': But if that code-wise makes the most sense, it's ok for me |
DonWillems
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1287
Added
applyConfigToAdminoption tomanager_config.json.It controls if custom page configurations are shown to the admin user.
Defaults to true.