Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DeathAdder V3 Pro (00c2/00c3) #2239

Merged

Conversation

ryan-1337
Copy link
Contributor

@ryan-1337 ryan-1337 commented Apr 27, 2024

Fixes #2214

@z3ntu z3ntu changed the title add support for deathadder v3 pro 2024 Add support for DeathAdder V3 Pro (00c2/00c3) Apr 28, 2024
@z3ntu
Copy link
Member

z3ntu commented Apr 28, 2024

Does any marketing material / names actually include "2024" in the name? If not please remove that from the name here, we already have several of such instances with other devices.

Also could you share here again what the status of this is? You wrote before "it's not detected by polychromatic" but do for example the udev rules trigger, the kernel driver bind, etc?

@ryan-1337
Copy link
Contributor Author

Can we rename the device to Deathadder v3 pro Smooth as described on the razer website instead of deathadder v3 pro 2024?

On my machine I can't load the drivers but on a vm everything loads fine.

@z3ntu
Copy link
Member

z3ntu commented Apr 28, 2024

I don't see the device being named that way? Sure, you can select "Smooth-Touch" as finish but it's not a part of the device name, and the "Classic Base" surely would be the same software-wise.

image

So I think just "DeathAdder V3 Pro" like the device that's already supported is fine. I think other devices with the same "problem" use e.g. _ALT in the driver (Ornata V3 X)

@z3ntu
Copy link
Member

z3ntu commented May 9, 2024

Why did you rename the device after I wrote #2239 (comment) ?

@ryan-1337
Copy link
Contributor Author

Why did you rename the device after I wrote #2239 (comment) ?

Sorry, I didn't quite understand.
it's fixed

@z3ntu
Copy link
Member

z3ntu commented May 9, 2024

So functionality-wise everything works correctly? Any functionality missing?

@ryan-1337
Copy link
Contributor Author

So functionality-wise everything works correctly? Any functionality missing?

yes, everything looks good to me

@ryan-1337 ryan-1337 requested a review from z3ntu May 17, 2024 22:55
@z3ntu z3ntu removed the In Progress label Jul 2, 2024
[Luca: unify more with 00b6/00b7 variant, rework fake driver duplicates]
@z3ntu z3ntu force-pushed the add_support_for_deathadder_v3_pro_2024 branch from 5ccc153 to d38009a Compare July 2, 2024 20:36
@z3ntu
Copy link
Member

z3ntu commented Jul 2, 2024

I've now tried to align the code more with the other DeathAdder V3 Pro since those two should have identical functionality.

By doing this for now I've removed the 8kHz polling rate and hyperpolling led indicator, let's add this later.

I'll merge this for now assuming it still works but please try the latest state also and let me know if it does or doesn't work.

@z3ntu z3ntu merged commit d38009a into openrazer:master Jul 2, 2024
2 checks passed
@z3ntu
Copy link
Member

z3ntu commented Jul 2, 2024

For the other functionality please pull deathadder_v3_pro_functionality into a branch of yours and check if it works still also, then open a PR from that. Thanks!

@ryan-1337
Copy link
Contributor Author

I've now tried to align the code more with the other DeathAdder V3 Pro since those two should have identical functionality.

By doing this for now I've removed the 8kHz polling rate and hyperpolling led indicator, let's add this later.

I'll merge this for now assuming it still works but please try the latest state also and let me know if it does or doesn't work.

Hello, after trying it, the mouse is no longer detected
Screenshot from 2024-07-03 23-23-42

@z3ntu
Copy link
Member

z3ntu commented Jul 3, 2024

Bah, nothing important was changed that should be able to cause this.

Are you sure you built correctly from master branch? Please check grep -i 00c3 /lib/udev/rules.d/99-razer.rules and dmesg for anything related to razermouse

@ryan-1337
Copy link
Contributor Author

ok it works mb problem of permissions i had to add this line
sudo chown -R root:plugdev /sys/devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for DeathAdder V3 Pro (2024)
2 participants