Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Razer BlackWidow V3 Pro (Wireless) #2231

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add support for Razer BlackWidow V3 Pro (Wireless) #2231

merged 1 commit into from
Jul 3, 2024

Conversation

lissyx
Copy link

@lissyx lissyx commented Apr 4, 2024 •
edited by z3ntu
Loading

@z3ntu Rebased against current master and looks to be working for me (aside from ripple?)

Fixes #1279

@lissyx lissyx mentioned this pull request Apr 4, 2024
Closed
@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from 9aa084d to f0e60e2 Compare April 4, 2024 07:10
@z3ntu
Copy link
Member

z3ntu commented Apr 6, 2024

If you rebase on git master then the CI shouldn't be broken anymore.

@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch 2 times, most recently from fd21635 to 7d12e88 Compare April 6, 2024 10:20
z3ntu
z3ntu reviewed Apr 6, 2024
View reviewed changes
driver/razerkbd_driver.c Outdated Show resolved Hide resolved
@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from 7d12e88 to a445cd6 Compare April 8, 2024 03:50
@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from a445cd6 to e912287 Compare April 18, 2024 13:36
@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from e912287 to 704fbed Compare May 13, 2024 09:16
@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from 704fbed to 7d4e752 Compare July 3, 2024 08:14
@z3ntu
Copy link
Member

z3ntu commented Jul 3, 2024

Please check the CI failure, if the device supports the low battery threshold settings, then please add the method to the daemon, if it doesn't support it, then please remove it from the driver to not have a mismatch of supported functionality in the two.

@lissyx
Copy link
Author

lissyx commented Jul 3, 2024 •
edited
Loading

Please check the CI failure, if the device supports the low battery threshold settings, then please add the method to the daemon, if it doesn't support it, then please remove it from the driver to not have a mismatch of supported functionality in the two.

I'll have a look, thanks for checking

I was wondering why I did not saw that earlier, it's because it was added """recently""" in commit d123186

@lissyx lissyx force-pushed the add_blackwidow_v3_pro_wireless branch from 7d4e752 to 0e8f64d Compare July 3, 2024 13:24
@z3ntu z3ntu force-pushed the add_blackwidow_v3_pro_wireless branch from 0e8f64d to 1c36fb4 Compare July 3, 2024 16:11
z3ntu
z3ntu approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@z3ntu z3ntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting this over the finish line!

@z3ntu z3ntu merged commit 1c36fb4 into openrazer:master Jul 3, 2024
2 checks passed
@lissyx
Copy link
Author

lissyx commented Jul 3, 2024

I mostly polished what was made ready by others, so thanks @nicfix and @YoMamasNerd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z3ntu z3ntu z3ntu approved these changes

Assignees
No one assigned
Labels
Device Support
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for BlackWidow V3 Pro [1532:025c]
3 participants
@lissyx @z3ntu @nicfix