Adds Logo LED Toggle for Razer Blade 15 (2019) Advanced #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently using a
Razer Blade 15 (2019) Advanced
and could not toggle my Logo LEDs viapolychromatic
.I followed the steps someone else did for the Mercury model here in #1001 to add support for the 2019 Advanced model as well.
Everything seems to work locally so far.
When I open the popup menu from my tray icon, I can toggle the logo with
On
orOff
under the brightness section. Works fine and as expected.But when I open the polychromatic controller, I'm getting an error. This is the error message when opening
polychromatic-controller
:This is how it looks like in the UI then:
Is there anything I would need to change to fix this? I'm sorry, I did not have the time to read through the whole codebase 🤦♂️