issue/28 - Text search for events #108
Conversation
shawnvarghese
changed the title
| start_time=start_time, | ||
| end_time=end_time, | ||
| ) | ||
| class HomepageView(View): |
There was a problem hiding this comment.
I refactored this view a little bit so that it is more consistent to the way the other views are coded.
shawnvarghese
force-pushed
the
issue/28
branch
from
b1f0a06
to
2ac6bdb
Compare
shawnvarghese
requested review from
adborden,
n8snyder,
mikeubell,
edmundonm,
kerrieyee and
lenayee7
| query = query & Q(start_datetime__range=(current_timezone.localize(start_date), | ||
| current_timezone.localize(end_date))) | ||
| if search: | ||
| query = query & (Q(title__icontains=search) | Q(description__icontains=search)) |
There was a problem hiding this comment.
As per the docs, it seems that we need to be using PostgreSQL DB before being able to use Django's full text search (https://docs.djangoproject.com/en/2.2/ref/contrib/postgres/search/)
So I thought I'll update this later when we migrate to Postgres. Currently, the search only matches title and description, but we would have to add more fields like location soon (#103)
| </div> | ||
| <div class="grid-col-4"> | ||
|
|
||
| <div class="grid-col-4 desktop:display-block mobile: display-none"> |
There was a problem hiding this comment.
As the calendar causes issues on mobile screens, I have disabled the datepicker for mobile for now. Should we have a different style of datepicker for mobile ui? Or maybe a button to toggle the calendar view on/off?
There was a problem hiding this comment.
I think we can just use a regular date select for mobile.
| @@ -114,7 +114,7 @@ | |||
| "pk": 6, | |||
| "fields": { | |||
| "title": "Approved CodeForSanJose Hack Night", | |||
| "description": "This is an event that is pending", | |||
| "description": "This is an event that is approved", | |||
| "recurrences": "RRULE:FREQ=WEEKLY;BYDAY=TU", | |||
| "start_datetime": "2019-10-12T18:30:00-0700", | |||
| "end_datetime": "2019-10-12T21:00:00-0700", | |||
There was a problem hiding this comment.
What do these changes have to do with Text Search?
There was a problem hiding this comment.
They dont; I was just correcting the description to keep it consistent with the title of the event.
I agree, I wasn't convinced of this either. But I had a look at meetup.com and it does something similar this. Would it be more intuitive if we persisted the search term in the search bar as we scrolled between months? |
shawnvarghese
force-pushed
the
issue/28
branch
from
8c1ef94
to
d7094d5
Compare
shawnvarghese
force-pushed
the
issue/28
branch
from
937ad0d
to
bb939ff
Compare
Added search capability to the webpage