Unit tests for parent distro

openmrs · Nov 15, 2024 · cbf22a8 · cbf22a8
1 parent 1ed8e29
commit cbf22a8
Show file tree

Hide file tree

Showing 2 changed files with 78 additions and 1 deletion.
diff --git a/sdk-commons/src/main/java/org/openmrs/maven/plugins/model/DistroProperties.java b/sdk-commons/src/main/java/org/openmrs/maven/plugins/model/DistroProperties.java
@@ -138,7 +138,7 @@ public Artifact getParentDistroArtifact() throws MojoExecutionException {
                 if (artifact != null) {
                     throw new MojoExecutionException("Only a single " + TYPE_DISTRO + " property can be added to indicate the parent distribution");
                 }
-                artifact = new Artifact(artifactId, version, groupId, type, Artifact.TYPE_JAR);
+                artifact = new Artifact(artifactId, version, groupId, type);
             }
         }
         String artifactId = getParam(TYPE_PARENT + "." + ARTIFACT_ID);

diff --git a/sdk-commons/src/test/java/org/openmrs/maven/plugins/model/DistroPropertiesTest.java b/sdk-commons/src/test/java/org/openmrs/maven/plugins/model/DistroPropertiesTest.java
@@ -96,6 +96,83 @@ public void resolvePlaceholders_shouldFailIfNoPropertyForPlaceholderFound() thro
         distro.resolvePlaceholders(getProjectProperties());
     }
 
+    @Test
+    public void getParentDistroArtifact_shouldGetFromDistroWithImplicitArtifact() throws MojoExecutionException {
+        Properties properties = new Properties();
+        properties.setProperty("distro.pihemr", "2.1.0");
+        properties.setProperty("distro.pihemr.groupId", "org.pih.openmrs");
+        properties.setProperty("distro.pihemr.type", "zip");
+        DistroProperties distro = new DistroProperties(properties);
+        Artifact distroArtifact = distro.getParentDistroArtifact();
+        assertThat(distroArtifact, notNullValue());
+        assertThat(distroArtifact.getArtifactId(), equalTo("pihemr"));
+        assertThat(distroArtifact.getVersion(), equalTo("2.1.0"));
+        assertThat(distroArtifact.getGroupId(), equalTo("org.pih.openmrs"));
+        assertThat(distroArtifact.getType(), equalTo("zip"));
+    }
+
+    @Test
+    public void getParentDistroArtifact_shouldGetFromDistroWithExplicitArtifact() throws MojoExecutionException {
+        Properties properties = new Properties();
+        properties.setProperty("distro.foo", "2.1.0");
+        properties.setProperty("distro.foo.artifactId", "pihemr");
+        properties.setProperty("distro.foo.groupId", "org.pih.openmrs");
+        properties.setProperty("distro.foo.type", "zip");
+        DistroProperties distro = new DistroProperties(properties);
+        Artifact distroArtifact = distro.getParentDistroArtifact();
+        assertThat(distroArtifact, notNullValue());
+        assertThat(distroArtifact.getArtifactId(), equalTo("pihemr"));
+        assertThat(distroArtifact.getVersion(), equalTo("2.1.0"));
+        assertThat(distroArtifact.getGroupId(), equalTo("org.pih.openmrs"));
+        assertThat(distroArtifact.getType(), equalTo("zip"));
+    }
+
+    @Test
+    public void getParentDistroArtifact_shouldGetFromParent() throws MojoExecutionException {
+        Properties properties = new Properties();
+        properties.setProperty("parent.version", "2.1.0");
+        properties.setProperty("parent.artifactId", "pihemr");
+        properties.setProperty("parent.groupId", "org.pih.openmrs");
+        properties.setProperty("parent.type", "jar");
+        DistroProperties distro = new DistroProperties(properties);
+        Artifact distroArtifact = distro.getParentDistroArtifact();
+        assertThat(distroArtifact, notNullValue());
+        assertThat(distroArtifact.getArtifactId(), equalTo("pihemr"));
+        assertThat(distroArtifact.getVersion(), equalTo("2.1.0"));
+        assertThat(distroArtifact.getGroupId(), equalTo("org.pih.openmrs"));
+        assertThat(distroArtifact.getType(), equalTo("jar"));
+    }
+
+    @Test
+    public void getParentDistroArtifact_shouldGetFromParentAndDefaultToZipType() throws MojoExecutionException {
+        Properties properties = new Properties();
+        properties.setProperty("parent.version", "2.1.0");
+        properties.setProperty("parent.artifactId", "pihemr");
+        properties.setProperty("parent.groupId", "org.pih.openmrs");
+        DistroProperties distro = new DistroProperties(properties);
+        Artifact distroArtifact = distro.getParentDistroArtifact();
+        assertThat(distroArtifact, notNullValue());
+        assertThat(distroArtifact.getArtifactId(), equalTo("pihemr"));
+        assertThat(distroArtifact.getVersion(), equalTo("2.1.0"));
+        assertThat(distroArtifact.getGroupId(), equalTo("org.pih.openmrs"));
+        assertThat(distroArtifact.getType(), equalTo("zip"));
+    }
+
+    @Test
+    public void getParentDistroArtifact_shouldNormalizeArtifact() throws MojoExecutionException {
+        Properties properties = new Properties();
+        properties.setProperty("parent.version", "2.1.0");
+        properties.setProperty("parent.artifactId", "referenceapplication");
+        properties.setProperty("parent.groupId", "org.openmrs.distro");
+        DistroProperties distro = new DistroProperties(properties);
+        Artifact distroArtifact = distro.getParentDistroArtifact();
+        assertThat(distroArtifact, notNullValue());
+        assertThat(distroArtifact.getArtifactId(), equalTo("referenceapplication-package"));
+        assertThat(distroArtifact.getVersion(), equalTo("2.1.0"));
+        assertThat(distroArtifact.getGroupId(), equalTo("org.openmrs.distro"));
+        assertThat(distroArtifact.getType(), equalTo("jar"));
+    }
+
     private static Artifact findArtifactByArtifactId(List<Artifact> artifacts, String artifactId){
         for(Artifact artifact : artifacts){
             if(artifact.getArtifactId().equals(artifactId)){