Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM2-648 fix NPE when querying deceased patient with openmrsPatients n… #553

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

chibongho
Copy link
Contributor

…amed query

Description of what I changed

fix NPE when querying deceased patient with openmrsPatients named query

Testing done:
Verify no NPE when going to: http://localhost:8080/openmrs/ws/fhir2/R4/Patient?_summary=data&_format=json&_query=openmrsPatients&q=test&deceased=true

Issue I worked on

see https://issues.openmrs.org/browse/FM2-648

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@dkayiwa
Copy link
Member

dkayiwa commented Oct 31, 2024

@chibongho did you get a chance to look at the build failures?

@chibongho
Copy link
Contributor Author

@dkayiwa I haven't had time to div into it yet. It seems unrelated to this change though, as I see the same failures in another PR:

https://github.com/openmrs/openmrs-module-fhir2/actions/runs/11459677696/job/31884705402

@ibacher ibacher merged commit 10a5c39 into master Nov 26, 2024
1 of 2 checks passed
@ibacher ibacher deleted the FM2-648 branch November 26, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants