FM-172. Added Tests for radiology handler #203
Conversation
| assertNotNull(radiologyHandler.getFHIRDiagnosticReportBySubjectName(name)); | ||
| } | ||
| catch(Exception e) | ||
| { |
There was a problem hiding this comment.
@haripriya999 , thank you very much for the great work. Quick question, why would you need to catch an Exception ?
There was a problem hiding this comment.
@Ruhanga Thank you for reviewing my code :) . There seems to be some problem with the variable, serverBase in RadiologyHandler, beacause of which a null pointer exception was being throw. I understood the root cause of the problem but I'm unsure of what the variable value should be set to. Hope this Talk would provide further details- https://talk.openmrs.org/t/error-variable-serverbase-in-radiologyhandler-is-returning-null/22511 . Also, I think we can create a new issue for this.
| catch(Exception e) | ||
| { | ||
| e.printStackTrace(); | ||
| } |
There was a problem hiding this comment.
Also can you consider https://wiki.openmrs.org/display/docs/Java+Conventions#JavaConventions-loggingLogging in case you want to printout anything though it would be unnecessary for this use case.
| <artifactId>openmrs-api</artifactId> | ||
| <version>${openMRSVersion}</version> | ||
| <type>test-jar</type> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
For what use-case is this change made?
There was a problem hiding this comment.
I followed this wiki page- https://wiki.openmrs.org/plugins/servlet/mobile?contentId=3346858#content/view/3346858
FM-172: Added Tests for Radiology Handler
Description of what I changed
Added tests in RadiologyHandlerTest.java
Issue I worked on
see https://issues.openmrs.org/browse/FM-172
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master