Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA-1747:Remove or hide admit button #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HerbertYiga
Copy link
Contributor

ticket Id:https://issues.openmrs.org/browse/RA-1747

Description
Remove or hide admit button

still in progress

@@ -118,6 +118,7 @@ ${ ui.includeFragment("coreapps", "patientHeader", [ patient: patient.patient, a
<h3 >${ ui.message("coreapps.clinicianfacing.activeVisitActions") }</h3>
<% visitActions.each { ext -> %>
<li class="float-left">
<% if(ext.label) != "Admit to inpatient" %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work if the label is in a language other than English?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkayiwa let me re -think the solution, also on the ticket description i see some thing like (Enters ADT Events role should theoretically not show the "Admit to inpatient" option for Standard Users) does this mean we disable the admin to inpatient for standard users? If true,i am requesting for some insights about the standard users!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we shouldn't be removing anything here, at the UI level... this seems more like some sort of ref app configuration issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mogoodrich looking at this ticket Id:https://issues.openmrs.org/browse/RA-1747,the ticket description is some how unclear to me on (when) the admit to patient button is not needed, this can give me an easy move on the (where) to make the fix,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants