(feat) O3-4370 : Discard Button to Return to Patient Search Instead of Closing Workspace #2265
+18
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isitForm components
3 tasks
here while clicking on the discard it close the workspace as normallyScreen.Recording.2025-02-25.at.3.56.30.PM.mov |
|
@denniskigen , @ibacher! Could you please review this PR |
…-in-the-queues-app-should-return-to-patient-chart
…-in-the-queues-app-should-return-to-patient-chart
…-in-the-queues-app-should-return-to-patient-chart
UNCANNY69
reviewed
Mar 2, 2025
| @@ -6,9 +6,10 @@ import { showSnackbar } from '@openmrs/esm-framework'; | |||
|
|
|||
| interface StartVisitButtonProps { | |||
| patientUuid: string; | |||
| handleBackToSearchList: () => void; | |||
There was a problem hiding this comment.
Hi @Muppasanipraneeth the solution looks perfect, small nitpick shouldn't this new attribute be optional as the start visit button is used in other locations where it does not need to go back to search visit
Suggested change
| handleBackToSearchList: () => void; | |
| handleBackToSearchList?: () => void; |
…-in-the-queues-app-should-return-to-patient-chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Screen.Recording.2025-02-25.at.2.53.56.PM.mov
Related Issue
Jira ticket
Other