Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix O3-4376 In the Visit Note form the Save and Discard buttons should always be visible #2259

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

EDSONZ-WASSWA
Copy link

@EDSONZ-WASSWA EDSONZ-WASSWA commented Feb 23, 2025

@ibacher please review this PR.
All buttons are flush with the bottom of the screen and fully allow all form controls to be visible
[Before]
After:!
[img-link-before](
query3

img-link-after

The link to the ticket click

@Muppasanipraneeth Muppasanipraneeth mentioned this pull request Feb 24, 2025
3 tasks
@EDSONZ-WASSWA
Copy link
Author

@ibacher this is a continuation of this PR (#2253) that i closed accidentally. Please kindly review it

@jwnasambu
Copy link
Contributor

@EDSONZ-WASSWA Kindly add a description of what you changed and ensure you attach a Jira ticket link, please!

@EDSONZ-WASSWA
Copy link
Author

Made the save and discard buttons visible and not overlapping others as before
ticket link

padding: 0;
bottom: 0;
padding:0;
left: 0;//Added this.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this comment..!

Copy link
Contributor

@Bharath-K-Shetty Bharath-K-Shetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EDSONZ-WASSWA , thanks for picking this up! Please ensure that your PR adheres to our template and follows the naming conventions specified in our contributing docs. In particular, the PR title should be formatted according to our guidelines. You can find all the details in the Pull Request Guidelines.

Copy link
Contributor

@Bharath-K-Shetty Bharath-K-Shetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EDSONZ-WASSWA it looks like the before and after images aren’t very clear.Can you please update it..!

@denniskigen denniskigen requested a review from vasharma05 March 4, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants