(feat) O3-4444: Map 'Start date' in drug order form to dateActivated
#2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +87 B (0%) Total Size: 16.3 MB ℹ️ View Unchanged
|
denniskigen
commented
Feb 12, 2025
| startDate: Date | string; | ||
| durationUnit: DurationUnit; | ||
| commonMedicationName: string; | ||
| dateActivated: Date | string; |
There was a problem hiding this comment.
Apologies from the diff noise from reordering these properties alphabetically. The key change here is renaming this property from startDate to dateActivated.
| asNeededCondition: medication.asNeededCondition, | ||
| careSetting: medication.careSetting?.uuid, | ||
| commonMedicationName: medication.drug?.display, | ||
| dateActivated: new Date(), |
There was a problem hiding this comment.
This is the key change, renaming this property from startDate to dateActivated.
| asNeededCondition: medication.asNeededCondition, | ||
| careSetting: medication.careSetting?.uuid, | ||
| commonMedicationName: medication.drug?.display, | ||
| dateActivated: medication?.dateActivated, |
There was a problem hiding this comment.
Key change: renaming this property from startDate to dateActivated and setting it's value to the existing medication's dateActivated property.
| commonMedicationName: drug.display, | ||
| isFreeTextDosage: false, | ||
| patientInstructions: '', | ||
| dateActivated: new Date(), |
There was a problem hiding this comment.
This is the key change: renaming this property from startDate to dateActivated.
…ivated` This PR makes the following changes to the medications app: - Maps the `startDate` field to the `dateActivated` property in the drug order form. Previously, the payload sent to the Order resource in the backend when creating a new drug order or editing an existing one was missing the `dateActivated` property. This meant that the backend wound up setting the `dateActivated` property to the current date and time. This is especially problematic when editing an existing order, as the current date was being used as the `dateActivated` property. This PR fixes this issue by mapping the `startDate` field to the `dateActivated` property and having its value default to the current date and time for new orders, and using the existing value for existing orders. - Amends the "Start date" field in the drug order form to read "Activation date" instead of "Start date". - Amends the "Start date" column header in the medications details table to read "Activation date" instead of "Start date".
denniskigen
force-pushed
the
feat/O3-4444
branch
from
95bf6b6 to
b6e77ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes the following changes to the medications app:
startDatefield to thedateActivatedproperty in the drug order form. Previously, the payload sent to the Order resource in the backend when creating a new drug order or editing an existing one was missing thedateActivatedproperty. This meant that the backend wound up setting thedateActivatedproperty to the current date and time. This is especially problematic when editing an existing order, as the current date was being used as thedateActivatedproperty. This PR fixes this issue by mapping thestartDatefield to thedateActivatedproperty and having its value default to the current date and time for new orders, and using the existing value for existing orders.Screenshots
Related Issue
Other