Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-4125: Vitals and Biometrics should not rely on concept search #2125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

D-matz
Copy link

@D-matz D-matz commented Dec 2, 2024

For O3-4125, not searching for "VITALS SIGNS" concept, instead getting it from packages\esm-patient-vitals-app\src\config-schema.ts

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-4125

Other

Not sure this is actually better, as now the concept UUID needs to be in the config file (and mockVitalsConfig). I'm new to openMRS, so if you had a different way of getting the concept please try that instead.

@jwnasambu
Copy link
Contributor

jwnasambu commented Dec 2, 2024

@D-matz kindly the commit message should read something like this chore/O3-4125: Vitals and Biometrics should not rely on concept search. Also, do you have a screenshot or video to attach to confirm if the issue is fixed?

@D-matz
Copy link
Author

D-matz commented Dec 3, 2024

@jwnasambu thank you, this is the vitals page (should be same as before) and the updated concept set result
vitals_resp
vitals_search

Will change to that commit message

@D-matz D-matz changed the title (chore) add vitals signs concept uuid to config-schema.ts, to not rely on string concept search (chore) O3-4125: Vitals and Biometrics should not rely on concept search Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants