(feat) Make the label in FormField optional to support Markdown content #411
Conversation
package.json
Outdated
| "rehype-raw": "^7.0.0", | ||
| "remark-gfm": "^4.0.0" |
There was a problem hiding this comment.
Do we need these three libraries?
|
@Twiineenock I think you need to commit the yarn.lock |
samuelmale
changed the title
| @@ -57,7 +57,7 @@ export interface FormSection { | |||
| } | |||
|
|
|||
| export interface FormField { | |||
| label: string; | |||
| label?: string; | |||
There was a problem hiding this comment.
@samuelmale this was changed to be optional because markdown type inputs don't have a label. Does this seem okay?
|
@Twiineenock can you resolve the conflicts and update your branch? |
| allowedElements={[ | ||
| 'h1', | ||
| 'h2', | ||
| 'h3', | ||
| 'h4', | ||
| 'h5', | ||
| 'h6', | ||
| 'p', | ||
| 'strong', | ||
| 'em', | ||
| ]} |
There was a problem hiding this comment.
@Twiineenock AFAICT, it doesn't seem as though allowedElements has changed per this this diff. Does that invalidate the PR title? Is the main change here that we're just bumping react-markdown?
There was a problem hiding this comment.
@denniskigen , I had added more allowedElements in the first commit.
I was later asked to maintain the current allowedElements as in this thread.
There was a problem hiding this comment.
And yes the PR title has to change! Thanks!
Twiineenock
changed the title
NethmiRodrigo
changed the title
NethmiRodrigo
changed the title
|
LGTM! Thanks @Twiineenock! |
Requirements
Summary
Problem Description
This pull request is part of ongoing work in PR #355.
In the interactive form builder, users should have the ability to create questions with markdown-rendered content. The markdown feature will allow question content to be formatted for better readability and accessibility.
Key Changes
Upgrade
react-markdownVersion:react-markdownfrom version^7.1.2to^9.0.1to support an expanded range of markdown formatting options.Extended Markdown Capabilities:
ReactMarkdowncomponent to support more plugins andallowedElementsfor enhanced markdown rendering.FormFieldinterface to handle cases where thelabelis absent, but avalueis present. This change provides more flexibility for displaying markdown content without requiring a label.Technical Details
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3946
Other