TRUNK-6259: Fixing the NullPointerException and ConcurrentModificationException #4778
Conversation
| // check user's privileges | ||
| notifyPrivilegeListeners(getAuthenticatedUser(), privilege, true); | ||
| return true; | ||
|
|
||
|
|
There was a problem hiding this comment.
Why are we adding a blank line here?
|
|
||
|
|
There was a problem hiding this comment.
Ditto for the extra blank lines here
wikumChamith
force-pushed
the
TRUNK-6259
branch
from
6eccd2f
to
2449f0e
Compare
wikumChamith
force-pushed
the
TRUNK-6259
branch
from
2449f0e
to
92e5eb2
Compare
I tested this locally and it worked well. Btw I am seeing the build errors on the master too. |
It will work, only because we are covering the bug again :) |
|
@wikumChamith Missed this part; are you able to reproduce the test failures locally, because I can't (from master), which makes them hard to track down... |
Locally, mvn clean install passes without any issues. However, when running the Log4JCompatibilityTest individually, it fails. I also re-ran the GitHub actions on my fork's master branch, which also failed. https://github.com/wikumChamith/openmrs-core/actions/runs/11257808859/job/31302920542 |
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master