Open
Conversation
Member
|
Being able to install with pip would be great. Eventually we want to make the whole OpenMM stack pip installable. |
Contributor
Author
|
Great! In theory it is straight forward to make pip just configure and call CMake when a pre built binary is not found, which is what I am trying to do here. |
Contributor
Author
|
I can do this from my laptop: $ mamba create -n nnpops && mamba activate nnpops
$ mamba install cudatoolkit-dev==11.7
$ pip install git+https://github.com/openmm/NNPOps@refs/pull/105/headThere are however some things I still do not know how to solve:
|
Member
|
The standard way of building pip packages is with cibuildwheel. It provides a set of standard build environments to ensure compatibility between packages. CUDA can be installed with pip. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an effort to include the possibility of installing NNPops via pip.
I mainly took the example here and adapted it:
https://github.com/pybind/cmake_example/blob/master/setup.py
Having pip as an option would simplify installing NNPops in environments which are not covered by the conda feedstock.
If this is not something that fits the current view of the project, please feel free to close this PR, @peastman.
I added a "pip wheel" section to the CI, lets see if it runs...