Update Group Context Extensions #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
May 16, 2024
franziskuskiefer
requested changes
May 17, 2024
…sterer/openmls into np/update-context-proposals
|
@nplasterer @cameronvoell let me know when I should look at this again. |
|
@nplasterer I made a PR to your fork branch here that updates the comment and adds a test nplasterer#1 |
Adds comment and new test for update_group_context_extensions
|
Merged @cameronvoell PR in. This should be ready for a review now @franziskuskiefer. 🙏 |
franziskuskiefer
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back to upstream the
update_group_context_extensionsmethod that we needed to get mutable metadata working.cc @cameronvoell @franziskuskiefer