Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional deserialization tls_codec feature to avoid code deduplication #1454

Closed
wants to merge 8 commits into from

Conversation

kkohbrok
Copy link
Member

No description provided.

@github-actions github-actions bot added size/s and removed size/m labels Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (303967c) 85.94% compared to head (92c5130) 85.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   85.94%   85.97%   +0.03%     
==========================================
  Files         170      170              
  Lines       19904    19870      -34     
==========================================
- Hits        17107    17084      -23     
+ Misses       2797     2786      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkohbrok kkohbrok added the blocked Not actionable label Jan 9, 2024
@kkohbrok
Copy link
Member Author

kkohbrok commented Jan 9, 2024

Unfortunately, the new conditionally_deserializable macro in tls_codec doesn't quite work for nested structs. I'll try to create a PR for tls_codec to ameliorate that. Blocked until then.

@github-actions github-actions bot added size/m and removed size/s labels Jan 22, 2024
@kkohbrok
Copy link
Member Author

kkohbrok commented Jul 9, 2024

This has become quite stale. I'll take another stab at this when I have the spare cycles.

@kkohbrok kkohbrok closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Not actionable size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants