-
Notifications
You must be signed in to change notification settings - Fork 598
Fix for plotting model with multi-group cross sections #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
paulromano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GuySten. I ended up removing all the extra code related to cross_sections. The recommended way to handle the data is to set openmc.config['mg_cross_sections'] before calling the plot() method. I'll comment on the original issue too.
|
There were a few problems:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the mishaps in my updates. I did make another change to simplify the additions to Model.plot. The reason that the relative path didn't work in the test is because for testing we set openmc.config['resolve_paths'] = False, so the relative path is kept. However, the default configuration for users is openmc.config['resolve_paths'] = True which means that it should work out of the box for users. Instead of introducing config.patch in Model.plot, I changed it so that we set the absolute path in the test. Let me know if you're OK with this now and if so, we're good to merge.
|
Now we are good to merge. |
Description
openmc crash when trying to plot a model with multigroup cross sections.
This PR fix that.
Fixes #3747
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)