Add cache builtin #308
Draft
Add cache builtin #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinshun
force-pushed
the
cache-builtin
branch
from
5ffa42b
to
87abfed
Compare
language/builtin.hlb
Outdated
| # If the image exists then use that image instead of executing input. | ||
| # | ||
| # @param input a filesystem to cache by vertex digest. | ||
| # @param ref a docker registry reference. if not fully qualified, it will be |
There was a problem hiding this comment.
Missing phrase at the end?
hinshun
force-pushed
the
cache-builtin
branch
from
87abfed
to
dc533c3
Compare
| @@ -3,6 +3,14 @@ | |||
| # @return a scratch filesystem. | |||
| fs scratch() | |||
|
|
|||
| # Caches an input fs by its vertex digest. | |||
| # If the image exists then use that image instead of executing input. | |||
There was a problem hiding this comment.
We should probably note that this pushes the image as well as building it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental. Maybe redundant with buildkit's export cache options.