Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merges the Typesetting Plugin in to the core of Janeway #4612

Open
wants to merge 346 commits into
base: master
Choose a base branch
from
Open

Merges the Typesetting Plugin in to the core of Janeway #4612

wants to merge 346 commits into from

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Feb 5, 2025 •
edited
Loading

The aim of this PR is not to overhaul anything but simply to make the Typesetting plugin a core Janeway application.

A brief summary:

  • Moves the Typesetting plugin into core and maintains its git history
  • Maintains the plugins/typesetting/ URL path but adds typesetting/ too
  • Renames the workflow element from Typesetting Plugin to typesetting for consistency
  • Updates the default workflow to include Typesetting, removes production and proofing
  • Plugin loading will ignore the Typesetting plugin
  • Merges events and settings into core modules

ajrbyers and others added 30 commits March 17, 2020 10:10
@ajrbyers @mauromsl
Proofreaders can be assigned without typesetters. Closes #21
082d05a
@ajrbyers @mauromsl
Updated wording.
5434bd8
@ajrbyers @mauromsl
Added some pep8 fixes
282035c
@ajrbyers @mauromsl
Closes #23
f59540f
@mauromsl @ajrbyers
Adds row hook for conversion plugins
fd2d92f
@ajrbyers @mauromsl
Updated handshake urls. Getting closer to 0.1!
52b95f3
@ajrbyers @mauromsl
Fixes jump and handshake urls.
6dba03f
@ajrbyers @mauromsl
Completes work on feature-hooks.
afeaf36
@mauromsl @ajrbyers
Adds support for typesetting corrections
1d600d8 
Corrections can be added on any typesetting round where a galley is
present.
- Typesetters will see a warning until they have done all corrections
- Managers will receive a prompt to act upon corrections not done
- Managers now have access to proofreader notes when creating rounds
@mauromsl @ajrbyers
Add validation to AssignTypesetter files
cc2a814
@ajrbyers
Feature emails (#29)
9c36a5e 
* Initial email commit.

* More work on emails!

* Closes #19

* Moves notification stuff to its own module.

* Made some changes. 

Logging is done in model method where possible, event raise from notify.py

* See note:

Splits notify and event firing. Views/logic fire events via notify and events registered funcs are defined in emails.py

* Addresses comment 

openlibhums/typesetting#29 (review)

* Addresses comment

openlibhums/typesetting#29 (comment)

* Set user=None where not explicitly required.
@ajrbyers @mauromsl
Completing a task marks it as accepted.
44db3dd
@ajrbyers @mauromsl
Added check to see if there is an existing accepted date.
0b5387c
@mauromsl
Corrections should not be a required form element
b2165c7
@ajrbyers @mauromsl
Added a migration to updated any old typesetting handshake urls
6ca75f4
@ajrbyers
#39: bugfix
163f68f 
* Completing a task marks it as accepted.

* Added check to see if there is an existing accepted date.

* Moved journal filter to initial query.
@ajrbyers @mauromsl
Updated dashboard block.
876775f
@ajrbyers @mauromsl
#36 for comments
f9635a8
@ajrbyers @mauromsl
Fixed permission on proofreader list.
992418d
@ajrbyers @mauromsl
Adds editors to the list of potential proofreders
07202e7
@ajrbyers @mauromsl
Closes #46
64b01e8
@mauromsl
Fixes a typo
877df06
@ajrbyers @mauromsl
50 fixes action page logic and expands a row in typesetting review.
f9caf40
@ajrbyers @mauromsl
Added completed lists to Typesetter and Proofreader lists.
f3feb69
@ajrbyers @mauromsl
#51 hide actions for all old rounds
c135dd3
@ajrbyers @mauromsl
#55 updates typesetting template.
bd9b094
@mauromsl @ajrbyers
#60: Fix callabale not being called
48bf96a
@ajrbyers @mauromsl
#62 Editing proofing assignment now uses jqte boxes.
4b8b0a3
@ajrbyers @mauromsl
#48 decouples save_galley from production logic so we can have a sing…
4cf8e62 
…le upload box
@ajrbyers @mauromsl
Added message for missing galley file
09cca30
joemull and others added 20 commits September 24, 2024 20:00
@joemull @mauromsl
Display typesetting guide to typesetter #31
c17433c
@mauromsl
Bump Janeway min version
1137d66
@ajrbyers @joemull
Display the typesetting task on the review page.
b191757
@ajrbyers @joemull
#217 alters layout and adds files table
f10f0df
@ajrbyers @joemull
#217 make phrasing the same
26da887
@ajrbyers @joemull
#217 adds galley files to display
b1a2911 
- Moves galley text and include to a new element template.
- Applies template to typesetter and review pages
@ajrbyers @mauromsl
fix: ensure processed_value is used for timestamp suffix (#223)
7fd3c7a
@mauromsl
Add 'src/typesetting/' from commit '7fd3c7aa61eac5b69588d286ffea51406…
488af78 
…d99be2e'

git-subtree-dir: src/typesetting
git-subtree-mainline: d9c1ea5
git-subtree-split: 7fd3c7a
@ajrbyers @mauromsl
Initial merge commit for typesetting.
2091c6e
@ajrbyers @mauromsl
chore: move typesetting event registration to core (#3277)
c03fc27
@ajrbyers @mauromsl
chore: fix url formatting (#3277)
3ec606b
@ajrbyers @mauromsl
chore: shift settings to core (#3277)
aa7ced6
@ajrbyers @mauromsl
chore: remove old markdown files (#3277)
62df48e
@ajrbyers @mauromsl
chore: tidies up typesetting stage name (#3277)
5ba53ef
@ajrbyers @mauromsl
fix: support typesetting plugin URL path (#3277)
ef369bc
@ajrbyers @mauromsl
fix: do not load the typesetting plugin (#3277)
6a448ca
@ajrbyers @mauromsl
fix: use consistent workflow element names (#3277)
9dbbda1
@ajrbyers @mauromsl
fix: change dashboard block header (#3277)
178abe4
@ajrbyers @mauromsl
fix: adds correct spacing above function def (#3277)
f8fe4d7
@ajrbyers @mauromsl
fix: handle proofing file upload when prod is in use (#3277)
380038f 
# Conflicts:
#	src/journal/views.py
@ajrbyers
Copy link
Member Author

ajrbyers commented Feb 5, 2025

  • Migrate the hook to core.

@mauromsl mauromsl added this to the v1.8.0 Tracker milestone Feb 6, 2025
@S-Haime S-Haime added the documentation Ideas for new or improved user documentation label Feb 6, 2025
@S-Haime
Copy link
Member

S-Haime commented Feb 6, 2025

Feel free to assign to me post merge. I can then check docs to make sure this reflects it. I may sit down with someone to check I ain't miss anything.

@ajrbyers ajrbyers requested a review from mauromsl February 6, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees

@mauromsl mauromsl

Labels
documentation Ideas for new or improved user documentation
Projects
None yet
Milestone
v1.8.0 Tracker
Development

Successfully merging this pull request may close these issues.
6 participants
@ajrbyers @S-Haime @mauromsl @hardyoyo @joemull @StephDriver