Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't look for an attribute on None object #4603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gamboz
Copy link
Collaborator

@gamboz gamboz commented Jan 29, 2025

Not particularly important, but I thought I'd report 🙂

In the decorator article_stage_accepted_or_later_or_staff_required, there is an if clause that might try to access an attribute of a None object.

To replicate, one should log-in to a journal and manually enter the URL of a non existing article in order to trigger the view "article_file_download" (views.serve_article_file).

E.g. https://olh.openlibhums.org/article/id/20000/file/1234/ (ATM article 20000 does not exist).

HTH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant