icon a11y notes removed #4215

openlibhums · Nov 25, 2024 · be729f2 · be729f2
1 parent 68b5e12
commit be729f2
Show file tree

Hide file tree

Showing 47 changed files with 0 additions and 115 deletions.
diff --git a/src/templates/common/elements/orcid_registration.html b/src/templates/common/elements/orcid_registration.html
@@ -5,7 +5,6 @@
     {% if orcid %}
         <p>
             ORCiD                            
-            {# IconA11y Semantic - alt text provided #}
             <a href="{{ orcid }}"><img alt="ORCID logo" src="{% static 'common/img/icons/orcid.gif' %}"> {{ orcid }}</a>&nbsp;
             [<a href="{% url 'core_register' %}">remove</a>]
         </p>

diff --git a/src/templates/common/elements/profile_image.html b/src/templates/common/elements/profile_image.html
@@ -1,5 +1,4 @@
 {% load static %}
-{# IconA11y Semantic - has text alternative#}
 <img
     class="{{ classes }}"
     src="{% if user.profile_image %}{{ user.profile_image.url }}{% elif request.journal.default_profile_image %}{{ request.journal.default_profile_image.url }}{% else %}{% static "common/img/icons/users.png" %}{% endif %}"

diff --git a/src/themes/OLH/templates/core/base.html b/src/themes/OLH/templates/core/base.html
@@ -91,7 +91,6 @@ <h1 class="menu-text">{{ request.journal.name }}</h1>
                     </div>
                     <div data-responsive-toggle="search-menu" data-hide-for="medium">
                         <a href="#" class="search-toggle" data-toggle aria-label="Search">
-                            {# IconA11y Semantic - updated with aria-label in a tag #}
                             <i aria-hidden="true" class="fa fa-search"></i>
                         </a>
                     </div>
@@ -151,7 +150,6 @@ <h1 class="menu-text">{{ request.journal.name }}</h1>
                         <form method="POST" action="{% url 'search' %}">
                             {% csrf_token %}
                             <div class="input-group">
-                                {# IconA11y Decorative - syntax updated #}
                                 <span class="input-group-label"><i aria-hidden="true" class="fa fa-search"></i></span>
                                 <input class="input-group-field" type="search" name="article_search" placeholder="{% trans 'Search' %}">
                                 <input type="hidden" name="sort" value="title">

diff --git a/src/themes/OLH/templates/core/homepage_elements/search_bar.html b/src/themes/OLH/templates/core/homepage_elements/search_bar.html
@@ -13,7 +13,6 @@
             <input id="title" name="title" type="hidden" value="on">
             <input id="abstract" name="abstract" type="hidden" value="on">
               <span class="input-group-label">
-                {# IconA11y Semantic - syntax updated #}
                 <i aria-hidden="true" class="fa fa-search"></i>
                 <span class="sr-only">Search</span>
               </span>

diff --git a/src/themes/OLH/templates/core/nav.html b/src/themes/OLH/templates/core/nav.html
@@ -43,15 +43,13 @@
         {% if request.journal.nav_start and not journal_settings.general.disable_journal_submission  %}
             <li>
                 <a href="{% url 'submission_start' %}" class="button">
-                    {# IconA11y Decorative - syntax updated #}
                     <i aria-hidden="true" class="fa fa-cloud-upload"></i> {% trans 'Start Submission' %}
                 </a>
             </li>
         {% endif %}
         {% if request.journal.nav_review %}
             <li>
                 <a href="{% url 'become_reviewer' %}" class="button">
-                    {# IconA11y Decorative - syntax updated #}
                     <i aria-hidden="true" class="fa fa-trophy"></i> 
                     {% trans 'Become a Reviewer' %}
                 </a>

diff --git a/src/themes/OLH/templates/core/news/item.html b/src/themes/OLH/templates/core/news/item.html
@@ -38,7 +38,6 @@ <h6>{{ news_item.byline }} on {{ news_item.posted|date:"Y-m-d" }}</h6>
                     {{ news_item.body|safe }}
                 </div>
                 <div class="large-3 columns">
-                    {# IconA11y Decorative - syntax updated #}
                     <h7>{% trans 'Tags ' %}<i aria-hidden="true" class="fa fa-tags">&nbsp;</i></h7>
                      <p>{% for tag in news_item.tags.all %}<a href="{% url 'core_news_list_tag' tag.text %}" class="button success tiny">{{ tag.text }}</a>{% if not forloop.last %}&nbsp;{% endif %}{% endfor %}</p>
                 </div>

diff --git a/src/themes/OLH/templates/elements/journal/box_article.html b/src/themes/OLH/templates/elements/journal/box_article.html
@@ -19,11 +19,9 @@
         {% endif %}
     <div class="{% if not journal_settings.article.disable_article_thumbnails %}large-10{% endif %} columns end">
         {% if article.pinned %}
-            {# IconA11y Semantic - syntax updated #}
             <i aria-hidden="true" class="float-right fa fa-thumb-tack"></i>
             <span class="sr-only">Pinned</span>
         {% endif %}
-            {# IconA11y Semantic - syntax updated #}
             <h2>{{ article.title|safe }}
                 {% if article.is_remote %}
                     &nbsp;<i aria-hidden="true" class="fa fa-external-link small-icon-text"></i>
@@ -33,19 +31,15 @@ <h2>{{ article.title|safe }}
            {% include "elements/journal/authors_block.html" %}
             <p>
                 <span class="date">
-                    {# IconA11y Decorative - updated from Semantic via time tag #}
                     <i aria-hidden="true" class="fa fa-calendar"></i>
                     <time datetime='{{ article.date_published|date:"Y-m-d" }}'>{{ article.date_published|date:"Y-m-d" }}</time>
                 </span> 
-                {# IconA11y Decorative - syntax updated #}
                 <i aria-hidden="true" class="fa fa-book"></i> {% if article.issue.issue_type.code == 'issue' %}{{ article.issue_title }}{% else %}{{ article.issue.issue_title }}{% endif %}</p>
             {% if article.issues.count > 1 %}
-            {# IconA11y Decorative - syntax updated #}
               <p><strong><i aria-hidden="true" class="fa fa-info-circle"></i> {% trans 'Also a part of:'%}</strong></p>
               {% for other in article.issues.all %}
               {% if other != article.issue %}
               <p>
-                {# IconA11y Decorative - syntax updated #}
                 <i aria-hidden="true" class="fa fa-book"></i>
                 <a class="issue-link" href="{{ other.url }}">
                     {{other.issue_type.pretty_name}}: {{ other.display_title }}

diff --git a/src/themes/OLH/templates/elements/journal/editorial_social_content.html b/src/themes/OLH/templates/elements/journal/editorial_social_content.html
@@ -4,7 +4,6 @@
         <a href="{{ user.website }}" 
             aria-label="{{ member.user.full_name }}'s website" 
             >
-            {# IconA11y Decorative - syntax updated #}
             <i aria-hidden="true"  class="fa fa-globe"></i> 
             {% trans 'Website' %}
         </a>
@@ -14,7 +13,6 @@
         <a href="https://www.twitter.com/{{ user.twitter }}" 
             aria-label="{{ member.user.full_name }}'s twitter profile"
             >
-            {# IconA11y Decorative - syntax updated #}
             <i aria-hidden="true"  class="fa fa-twitter-square"></i> 
             {% trans 'Twitter' %}
         </a>
@@ -24,7 +22,6 @@
         <a href="https://www.facebook.com/{{ user.facebook }}" 
             aria-label="{{ member.user.full_name }}'s facebook profile"
             >
-            {# IconA11y Decorative - syntax updated #}
             <i aria-hidden="true"  class="fa fa-facebook-square"></i> 
             {% trans 'Facebook' %}
         </a>
@@ -34,7 +31,6 @@
         <a href="https://www.github.com/{{ user.github}}" 
             aria-label="{{ member.user.full_name }}'s github profile"
             >
-            {# IconA11y Decorative - syntax updated #}
             <i aria-hidden="true"  class="fa fa-github-square"></i> 
             {% trans 'Github' %}
         </a>
@@ -44,7 +40,6 @@
         <a href="https://www.linkedin.com/in/{{ user.linkedin }}" 
             aria-label="{{ member.user.full_name }}'s linkedin profile"
             >
-            {# IconA11y Decorative - syntax updated #}
             <i aria-hidden="true" class="fa fa-linkedin-square"></i> 
             {% trans 'Linkedin' %}
         </a>

diff --git a/src/themes/OLH/templates/elements/journal/issue_sidebar.html b/src/themes/OLH/templates/elements/journal/issue_sidebar.html
@@ -7,7 +7,6 @@
             <h3>{% trans 'Downloads' %}</h3>
             <p>
                 <a href="{% url 'journal_issue_download_galley' issue.pk issue.galley.pk %}">
-                    {# IconA11y Decorative - syntax updated #}
                     <i aria-hidden="true"  class="fa fa-download">&nbsp</i>
                     {% trans "Download Issue" %} (PDF)
                 </a>

diff --git a/src/themes/OLH/templates/elements/journal/preprint_article_listing.html b/src/themes/OLH/templates/elements/journal/preprint_article_listing.html
@@ -5,7 +5,6 @@
                  data-equalizer-watch>
                 <p><small><a href="{% url 'repository_preprint' preprint.pk %}">{{ preprint.title|safe }}</a></small></p>
                 <p><small><i>{% for author in preprint.authors.all %}{{ author.full_name }}{% if not forloop.last %}, {% endif %}{% endfor %}</i></small></p>
-                {# IconA11y Decorative - updated from Semantic via time tag #}
                 <p><small>
                     <i aria-hidden="true" class="fa fa-calendar">&nbsp;</i>
                     <time datetime='{{ preprint.date_published|date:"Y-m-d" }}'>{{ preprint.date_published|date:"Y-m-d" }}</time>

diff --git a/src/themes/OLH/templates/elements/public_reviews.html b/src/themes/OLH/templates/elements/public_reviews.html
@@ -4,7 +4,6 @@
              data-animation-out="slide-out-down">
             <div class="card">
                 <div class="card-divider">
-                    {# IconA11y Decorative - syntax updated #}
                     <h4><i aria-hidden="true" class="fa fa-pencil">&nbsp;</i>Open peer review from {{ review.reviewer.full_name }}
                     </h4>
                 </div>

diff --git a/src/themes/OLH/templates/elements/section_block.html b/src/themes/OLH/templates/elements/section_block.html
@@ -24,11 +24,9 @@ <h3>{% trans 'Sections' %}</h3>
             <td>
                 <strong>
                     {% if section.public_submissions %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-check" title="{% trans 'yes' %}"></i>
                         <span class="sr-only">{% trans 'yes' %}</span>
                     {% else %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-times" title="{% trans 'no' %}"></i>
                         <span class="sr-only">{% trans 'no' %}</span>
                     {% endif %}
@@ -37,11 +35,9 @@ <h3>{% trans 'Sections' %}</h3>
             <td>
                 <strong>
                     {% if section.number_of_reviewers > 0 %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-check" title="{% trans 'yes' %}"></i>
                         <span class="sr-only">{% trans 'yes' %}</span>
                     {% else %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-times" title="{% trans 'no' %}"></i>
                         <span class="sr-only">{% trans 'no' %}</span>
                     {% endif %}
@@ -50,11 +46,9 @@ <h3>{% trans 'Sections' %}</h3>
             <td>
                 <strong>
                     {% if section.indexing %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-check" title="{% trans 'yes' %}"></i>
                         <span class="sr-only">{% trans 'yes' %}</span>
                     {% else %}
-                        {# IconA11y Semantic - syntax updated #}
                         <i aria-hidden="true" class="fa fa-times" title="{% trans 'no' %}"></i>
                         <span class="sr-only">{% trans 'no' %}</span>
                     {% endif %}

diff --git a/src/themes/OLH/templates/elements/submit/author.html b/src/themes/OLH/templates/elements/submit/author.html
@@ -5,7 +5,6 @@
      data-animation-out="slide-out-down">
     <div class="card">
         <div class="card-divider">
-            {# IconA11y Decorative - syntax updated #}
             <h4><i aria-hidden="true"  class="fa fa-user">&nbsp;</i>{% trans "Add New Author" %}</h4>
         </div>
         <div class="card-section">
@@ -61,7 +60,6 @@ <h4><i aria-hidden="true"  class="fa fa-user">&nbsp;</i>{% trans "Add New Author
                     </div>
                 </div>
 
-                {# IconA11y Decorative - syntax updated #}
                 <button class="success button pull-right" type="submit" name="add_author"><i aria-hidden="true" class="fa fa-user">
                     &nbsp;</i>{% trans "Add Author" %}
                 </button>

diff --git a/src/themes/OLH/templates/journal/article.html b/src/themes/OLH/templates/journal/article.html
@@ -33,7 +33,6 @@ <h2>{{ article.title|safe }}</h2>
                             {% if author.orcid %}<a href="https://orcid.org/{{ author.orcid }}" class=""><img src="https://orcid.org/sites/default/files/images/orcid_16x16.png" alt="orcid logo"></a>{% endif %}
                             {% if author.institution and author.institution != " " %} ({{ author.institution }}){% endif %}
                         {% if author.display_email and not journal_settings.article.hide_author_email_links %}
-                            {# IconA11y Semantic - syntax update #}
                             <a itemprop="email" href="mailto:{{ author.email }}" aria-label="Email author" class="fa fa-envelope email-link"></a>
                         {% endif %}
                         {% if not forloop.last %}, {% endif %}
@@ -83,7 +82,6 @@ <h3>{{ article.title|safe }}</h3>
                                             <span itemprop="worksFor" itemscope
                                                   itemtype="http://schema.org/CollegeOrUniversity"><span
                                                     itemprop="name">({{ author.institution }})</span></span>{% endif %}
-                                            {# IconA11y Semantic - syntax updated #}
                                             {% if author.display_email and not journal_settings.article.hide_author_email_links %}
                                                 <a itemprop="email" href="mailto:{{ author.email }}"
                                                     class="fa fa-envelope email-link"
@@ -123,11 +121,9 @@ <h3>{{ article.title|safe }}</h3>
                                 data-responsive-menu="drilldown medium-dropdown">
                               {% with article.get_doi_url as doi_url %}
                                 <li>{% trans "Share" %}:</li>
-                                {# IconA11y Semantic - syntax updated #}
                                 <li><a href="https://www.facebook.com/share.php?p[url]={% if doi_url %}{{ doi_url }}{% else %}{{ article.url }}{% endif %}" target="_blank" aria-label="{% trans 'Share on Facebook' %}"><i aria-hidden="true" class="fa fa-facebook"></i></a></li>
                                 <li><a class= "twitter-x"
                                     href="https://twitter.com/intent/tweet?text={{ article.title }} {% if doi_url %}{{ doi_url }}{% else %}{{ article.url }}{% endif %}" target="_blank" aria-label="{% trans 'Share on X' %}"><span aria-hidden="true">&#120143;</span></a></li>
-                                {# IconA11y Semantic - syntax updated #}
                                 <li><a href="https://www.linkedin.com/sharing/share-offsite?url={% if doi_url %}{{ doi_url }}{% else %}{{ article.url }}{% endif %}" target="_blank" aria-label="{% trans 'Share on LinkedIn' %}"><i aria-hidden="true" class="fa fa-linkedin"></i></a></li>
                               {% endwith %}
                             </ul>
@@ -141,7 +137,6 @@ <h3>{{ article.title|safe }}</h3>
                                         <a href="{{ article.local_url }}print/" 
                                             aria-label="{% trans 'print article' %}"
                                             >
-                                            {# IconA11y Semantic - updated syntax #}
                                             <i aria-hidden="true" class="fa fa-print">&nbsp;</i>
                                         </a>
                                     </li>
@@ -152,15 +147,13 @@ <h3>{{ article.title|safe }}</h3>
                                             <a href="mailto:{{ article.correspondence_author.email }}"
                                                 aria-label="email author"
                                             >
-                                                {# IconA11y Semantic - updated via aria-label in a tag #}
                                                 <i aria-hidden="true" class="fa fa-envelope"></i>
                                             </a>
                                         </li>
                                     {% endif %}
                                     <li><a href="#" id="dyslexia-mode" aria-label="{% trans 'Dyslexia mode' %}">{% trans "Dyslexia" %}</a></li>
                                     <li>
                                         <a href="#" aria-label="{% trans 'Cite article' %}">
-                                            {# IconA11y Semantic - syntax updated #}
                                             <i aria-hidden="true" class="fa fa-comments">&nbsp;</i>
                                         </a>
                                         <ul class="menu vertical">
@@ -199,7 +192,6 @@ <h1>{{ article.title|safe }}</h1>
                             {% if author.orcid %}<a href="https://orcid.org/{{ author.orcid }}" class=""><img src="https://orcid.org/sites/default/files/images/orcid_16x16.png" alt="orcid logo"></a>{% endif %}
                             {% if author.institution and author.institution != " " %} ({{ author.institution }}){% endif %}
                             {% if author.display_email and not journal_settings.article.hide_author_email_links %}
-                                {# IconA11y Semantic - syntax updated #}
                                 <a itemprop="email" 
                                     href="mailto:{{ author.email }}" 
                                     aria-label="Email author"
@@ -258,7 +250,6 @@ <h2>{% trans "Publisher Notes" %}</h2>
                                         </p>
                                         {% if proofing %}
                                             <p id="note_to_proofreader_1">
-                                                {# IconA11y Decorative - syntax updated #}
                                                 <i aria-hidden="true" class="fa fa-info"></i>
                                                 Note to proofreader: Download links on this page begin to work when the article is published.
                                             </p>
@@ -361,7 +352,6 @@ <h4>{% trans "Authors" %}</h4>
                                                 </a>
                                                 {% endif %}
                                                 {% if author.display_email and not journal_settings.article.hide_author_email_links %}
-                                                    {# IconA11y Semantic - syntax updated #}
                                                     <a itemprop="email" 
                                                         href="mailto:{{ author.email }}" 
                                                         class="fa fa-envelope email-link"
@@ -394,7 +384,6 @@ <h3>{% trans "Downloads" %}</h3>
                                         </ul>
                                         {% if proofing %}
                                             <p id="note_to_proofreader_2">
-                                                {# IconA11y Decorative - syntax updated #}
                                                 <i aria-hidden="true"  class="fa fa-info"></i>
                                                 Note to proofreader: Download links on this page begin to work when the article is published.
                                             </p>

diff --git a/src/themes/OLH/templates/journal/print.html b/src/themes/OLH/templates/journal/print.html
@@ -23,7 +23,6 @@ <h3>{{ article.title|safe }}</h3>
             <span itemprop="worksFor" itemscope
                   itemtype="http://schema.org/CollegeOrUniversity"><span
                     itemprop="name">({{ author.institution }})</span></span>{% endif %}
-            {# IconA11y Semantic - syntax updated #}
             <a itemprop="email" href="mailto:{{ author.email }}"
                class="fa fa-envelope email-link"
                aria-label="Email author."></a></span></span>

diff --git a/src/themes/OLH/templates/press/core/news/item.html b/src/themes/OLH/templates/press/core/news/item.html
@@ -38,7 +38,6 @@ <h6>{% trans "Posted by" %} {{ news_item.posted_by.full_name }} {% trans "on" %}
                     {{ news_item.body|safe }}
                 </div>
                 <div class="large-3 columns">
-                    {# IconA11y Decorative - syntax updated #}
                     <h7>{% trans "Tags" %} <i aria-hidden="true"  class="fa fa-tags">&nbsp;</i></h7>
                      <p>{% for tag in news_item.tags.all %}<a href="{% url 'core_news_list_tag' tag.text %}" class="button success tiny">{{ tag.text }}</a>{% if not forloop.last %}&nbsp;{% endif %}{% endfor %}</p>
                 </div>