Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: mlpack 3: a fast, flexible machine learning library #703

Closed
whedon opened this issue Apr 25, 2018 · 32 comments
Closed

[PRE REVIEW]: mlpack 3: a fast, flexible machine learning library #703

whedon opened this issue Apr 25, 2018 · 32 comments

Comments

@whedon
Copy link

whedon commented Apr 25, 2018

Submitting author: @rcurtin (Ryan Curtin)
Repository: https://github.com/mlpack/mlpack
Version: v3.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @rasbt, @MikeInnes, @mlgill

Author instructions

Thanks for submitting your paper to JOSS @rcurtin. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@rcurtin if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 25, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Apr 25, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon whedon added the TeX label Apr 25, 2018
@whedon
Copy link
Author

whedon commented Apr 25, 2018

@arfon
Copy link
Member

arfon commented Apr 25, 2018

@rcurtin - many thanks for your submission. Is there anything stopping you from moving the paper into the https://github.com/mlpack/mlpack repository? This is our preferred way of handling submissions.

The paper.md file can exist basically anywhere in the https://github.com/mlpack/mlpack/ repo (e.g. nested somewhere under the docs folder)

@rcurtin
Copy link

rcurtin commented Apr 25, 2018

@arfon thanks for the quick reply. If it's necessary, we can move the paper into the repository, but to me it seems that the paper itself is a separate artifact from the code. (As time goes on, the paper itself may become out of date, for example.) I think that the Armadillo submission, which I was also involved with, had the paper in a separate place also. Let me know what you think.

I see that there are some minor issues with the paper; I will handle those. But I do have a question: some of our authors chose to have no affiliation for this paper, but it looks like the paper has compiled such that their affiliation has default-chosen the first affiliation. Is there a way to specify no affiliation? I don't see anything in the documentation.

@rcurtin
Copy link

rcurtin commented Apr 25, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 25, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 25, 2018

@arfon
Copy link
Member

arfon commented Apr 26, 2018

@arfon thanks for the quick reply. If it's necessary, we can move the paper into the repository, but to me it seems that the paper itself is a separate artifact from the code. (As time goes on, the paper itself may become out of date, for example.) I think that the Armadillo submission, which I was also involved with, had the paper in a separate place also. Let me know what you think.

This is a hard requirement for us these days. Our editorial system is heavily automated and so the current layout (paper not being with the software) means manual work for our editorial team.

@rcurtin
Copy link

rcurtin commented Apr 30, 2018

Ok, if it is a hard requirement, we have gone ahead and merged the paper.md into the mlpack/mlpack repository. The repository is now:

https://github.com/mlpack/mlpack

and the paper is located at:

https://github.com/mlpack/mlpack/tree/master/doc/joss_paper

Please let me know if that works, and if I didn't do it right just let me know and I can fix it. Thanks!

@arfon
Copy link
Member

arfon commented May 3, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 3, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 3, 2018

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented May 5, 2018

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@rcurtin thanks for this submission. I'm going to start looking for reviewers. Are you able to suggest any reviewers at this point?

@Kevin-Mattheus-Moerman
Copy link
Member

@rcurtin minor point on the paper, can you please add DOI's to all references that have them. Thanks.

@Kevin-Mattheus-Moerman
Copy link
Member

Review invitation. @MikeInnes @betatim @rasbt @cxhernandez @mlgill @rhiever would you be interested in reviewing this submission?

-->project repo 💾 <--
--> Paper 📄 <--

@rasbt
Copy link

rasbt commented May 6, 2018

i would be happy to do that. Timeline-wise, I think I will be able to get started on that later this week or next weekend.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @rasbt as reviewer

@whedon
Copy link
Author

whedon commented May 7, 2018

OK, the reviewer is @rasbt

@Kevin-Mattheus-Moerman
Copy link
Member

I'll initiate the actual review process shortly but aim to wait for some more reviewers to join.

@MikeInnes
Copy link

I'll review (my time for it might be a bit scattered over the next couple of weeks though).

@mlgill
Copy link

mlgill commented May 7, 2018 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @MikeInnes as reviewer

@whedon
Copy link
Author

whedon commented May 7, 2018

OK, @MikeInnes is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @mlgill as reviewer

@whedon
Copy link
Author

whedon commented May 7, 2018

OK, @mlgill is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented May 7, 2018

OK, I've started the review over in #726. Feel free to close this issue now!

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented May 7, 2018

Okay @rcurtin @mlgill @rasbt @MikeInnes I've started the review issue over at #726

@rcurtin
Copy link

rcurtin commented May 7, 2018

@Kevin-Mattheus-Moerman: thanks for your help with this! I didn't have any suggested reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants