8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
These are parity backports with Oracle's 8u461, OpenJDK 8u462 is affected. The commit 46251bc6 didn't apply cleanly as JDK-8049870 hasn't been backported to jdk8u-dev. JDK-8290162 is basically a clean backport, the paths changed to 8u path scheme. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test in TestJOptionHTMLTag.java was rewritten to get rid of dependency on PassFailJFrame (not in 8). Replaced the text block (JEP 355 style) with traditional string literals. The paths have been changed to the 8u path scheme. The test passes with the fix and fails otherwise.
Thanks!
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/659/head:pull/659
$ git checkout pull/659
Update a local copy of the PR:
$ git checkout pull/659
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/659/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 659
View PR using the GUI difftool:
$ git pr show -t 659
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/659.diff
Using Webrev
Link to Webrev Comment