Skip to content

8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sercher
Copy link
Contributor

@sercher sercher commented Jun 4, 2025

Hi all,

These are parity backports with Oracle's 8u461, OpenJDK 8u462 is affected. The commit 46251bc6 didn't apply cleanly as JDK-8049870 hasn't been backported to jdk8u-dev. JDK-8290162 is basically a clean backport, the paths changed to 8u path scheme. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test in TestJOptionHTMLTag.java was rewritten to get rid of dependency on PassFailJFrame (not in 8). Replaced the text block (JEP 355 style) with traditional string literals. The paths have been changed to the 8u path scheme. The test passes with the fix and fails otherwise.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8042134 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-5074006 needs maintainer approval
  • JDK-8224267 needs maintainer approval
  • JDK-8290162 needs maintainer approval

Issues

  • JDK-8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError (Bug - P3)
  • JDK-8290162: Reset recursion counter missed in fix of JDK-8224267 (Bug - P4 - Requested)
  • JDK-5074006: Swing JOptionPane shows </html> tag as a string after newline (Bug - P4 - Requested)
  • JDK-8042134: JOptionPane bungles HTML messages (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/659/head:pull/659
$ git checkout pull/659

Update a local copy of the PR:
$ git checkout pull/659
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 659

View PR using the GUI difftool:
$ git pr show -t 659

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/659.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2025

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 46251bc6e248a19e8d78173ff8d0502c68ee1acb 8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError Jun 4, 2025
@openjdk
Copy link

openjdk bot commented Jun 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2025

Webrevs

@sercher
Copy link
Contributor Author

sercher commented Jun 9, 2025

/issue add 8290162,5074006,8042134

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@sercher
Adding additional issue to issue list: 8290162: Reset recursion counter missed in fix of JDK-8224267.

Adding additional issue to issue list: 5074006: Swing JOptionPane shows </html> tag as a string after newline.

Adding additional issue to issue list: 8042134: JOptionPane bungles HTML messages.

@openjdk openjdk bot added the approval label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant